Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[apriltag] Better description of pose coordinates (NFC) #4810

Merged
merged 8 commits into from
Dec 14, 2022
Merged

[apriltag] Better description of pose coordinates (NFC) #4810

merged 8 commits into from
Dec 14, 2022

Conversation

bovlb
Copy link
Contributor

@bovlb bovlb commented Dec 13, 2022

The "bottom-left" language appears to be based on a 2-D diagram on another page and doesn't seem very helpful here.

@bovlb
Better description of pose co-ordinates
a4822c2 
The "bottom-left" language appears to be based on [a 2-D diagram  on another page](https://docs.wpilib.org/en/stable/docs/software/advanced-controls/geometry/coordinate-systems.html) and doesn't seem very helpful here.
@bovlb bovlb requested a review from a team as a code owner December 13, 2022 22:53
rzblue
rzblue requested changes Dec 13, 2022
View reviewed changes
Copy link
Member

@rzblue rzblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be done for the C++ version as well

calcmogul
calcmogul previously requested changes Dec 14, 2022
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use "coordinate" instead of "co-ordinate", but otherwise looks good.

@rzblue
Copy link
Member

rzblue commented Dec 14, 2022

/format

@rzblue
Copy link
Member

rzblue commented Dec 14, 2022

Let CI fix the formatting- don't commit any more

@rzblue rzblue changed the title Better description of pose co-ordinates [apriltag] Better description of pose co-ordinates (NFC) Dec 14, 2022
@PeterJohnson PeterJohnson changed the title [apriltag] Better description of pose co-ordinates (NFC) [apriltag] Better description of pose coordinates (NFC) Dec 14, 2022
@PeterJohnson PeterJohnson merged commit 2a5e89f into wpilibsuite:main Dec 14, 2022
@bovlb bovlb deleted the patch-3 branch December 14, 2022 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzblue rzblue rzblue approved these changes

@calcmogul calcmogul calcmogul left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bovlb @rzblue @calcmogul @PeterJohnson