Skip to content

make order processing methods static #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kidunot89 merged 1 commit into from
Oct 15, 2021
Merged

make order processing methods static #566

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions includes/data/mutation/class-checkout-mutation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,7 @@ protected static function validate_checkout( &$data ) {
*
* @return array.
*/
protected function process_order_payment( $order_id, $payment_method ) {
protected static function process_order_payment( $order_id, $payment_method ) {
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method process_order_payment is not named in camelCase.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter $order_id is not named in camelCase.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter $payment_method is not named in camelCase.

$available_gateways = WC()->payment_gateways->get_available_payment_gateways();

if ( ! isset( $available_gateways[ $payment_method ] ) ) {
Expand Down Expand Up @@ -538,7 +538,7 @@ protected function process_order_payment( $order_id, $payment_method ) {
*
* @return array
*/
protected function process_order_without_payment( $order_id, $transaction_id = '' ) {
protected static function process_order_without_payment( $order_id, $transaction_id = '' ) {
Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method process_order_without_payment is not named in camelCase.

Copy link

@qlty-cloud-legacy qlty-cloud-legacy bot Oct 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The parameter $order_id is not named in camelCase.

$order = wc_get_order( $order_id );
$order->payment_complete( $transaction_id );
wc_empty_cart();
Expand Down