make order processing methods static #566
Conversation
![qlty-cloud-legacy[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
| * @return array. | ||
| */ | ||
| protected function process_order_payment( $order_id, $payment_method ) { | ||
| protected static function process_order_payment( $order_id, $payment_method ) { |
There was a problem hiding this comment.
The method process_order_payment is not named in camelCase.
| * @return array. | ||
| */ | ||
| protected function process_order_payment( $order_id, $payment_method ) { | ||
| protected static function process_order_payment( $order_id, $payment_method ) { |
There was a problem hiding this comment.
The parameter $order_id is not named in camelCase.
| * @return array. | ||
| */ | ||
| protected function process_order_payment( $order_id, $payment_method ) { | ||
| protected static function process_order_payment( $order_id, $payment_method ) { |
There was a problem hiding this comment.
The parameter $payment_method is not named in camelCase.
| * @return array | ||
| */ | ||
| protected function process_order_without_payment( $order_id, $transaction_id = '' ) { | ||
| protected static function process_order_without_payment( $order_id, $transaction_id = '' ) { |
There was a problem hiding this comment.
The method process_order_without_payment is not named in camelCase.
| * @return array | ||
| */ | ||
| protected function process_order_without_payment( $order_id, $transaction_id = '' ) { | ||
| protected static function process_order_without_payment( $order_id, $transaction_id = '' ) { |
There was a problem hiding this comment.
The parameter $order_id is not named in camelCase.
|
Code Climate has analyzed commit 24d9570 and detected 7 issues on this pull request. Here's the issue category breakdown:
The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 77.0% (0.0% change). View more on Code Climate. |
2 participants
This should fix Checkout mutation returns error
Fixes #539
From what I can tell these methods are only called statically, so I think it's an easy fix.
Where has this been tested?