-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: shorten overly long name for HMSS Mill Deployment #1692
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/k8s/dev/duchy_eks.cue
line 104 at r1 (raw file):
"herald-daemon": "duchy/aws-herald" "computation-control-server": "duchy/aws-computation-control" "liquid-legions-v2-mill-daemon": "duchy/aws-liquid-legions-v2-mill"
nit: what about renaming llv2 as well to keep them in the same pattern?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
src/main/k8s/dev/duchy_eks.cue
line 104 at r1 (raw file):
Previously, renjiezh wrote…
nit: what about renaming llv2 as well to keep them in the same pattern?
I'd rather avoid the churn. Each rename may require action by operators.
9d36901
to
8760f1c
Compare
The name is too long for the standard metadata name field. BREAKING CHANGE: Renames a K8s Deployment in the dev configuration.
8760f1c
to
413200c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 7 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
The name is too long for the standard metadata name field. BREAKING CHANGE: Renames a K8s Deployment in the dev configuration.
The name is too long for the standard metadata name field.
BREAKING CHANGE: Renames a K8s Deployment in the dev configuration.