Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: shorten overly long name for HMSS Mill Deployment #1692

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

SanjayVas
Copy link
Member

The name is too long for the standard metadata name field.

BREAKING CHANGE: Renames a K8s Deployment in the dev configuration.

@SanjayVas SanjayVas requested a review from renjiezh July 16, 2024 22:34
@wfa-reviewable
Copy link

This change is Reviewable

Copy link
Contributor

@renjiezh renjiezh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/k8s/dev/duchy_eks.cue line 104 at r1 (raw file):

		"herald-daemon":                  "duchy/aws-herald"
		"computation-control-server":     "duchy/aws-computation-control"
		"liquid-legions-v2-mill-daemon":  "duchy/aws-liquid-legions-v2-mill"

nit: what about renaming llv2 as well to keep them in the same pattern?

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)


src/main/k8s/dev/duchy_eks.cue line 104 at r1 (raw file):

Previously, renjiezh wrote…

nit: what about renaming llv2 as well to keep them in the same pattern?

I'd rather avoid the churn. Each rename may require action by operators.

The name is too long for the standard metadata name field.

BREAKING CHANGE: Renames a K8s Deployment in the dev configuration.
@SanjayVas SanjayVas force-pushed the sanjayvas-hmss-deployment-name branch from 8760f1c to 413200c Compare July 17, 2024 18:22
Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 7 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas merged commit e9fd799 into main Jul 18, 2024
4 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-hmss-deployment-name branch July 18, 2024 17:19
ple13 pushed a commit that referenced this pull request Aug 16, 2024
The name is too long for the standard metadata name field.

BREAKING CHANGE: Renames a K8s Deployment in the dev configuration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants