Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: enable horizontal autoscaling of Liquid Legions v2 Mill via CronJobs #1686

Closed
wants to merge 2 commits into from
Closed

feat!: enable horizontal autoscaling of Liquid Legions v2 Mill via CronJobs #1686

wants to merge 2 commits into from

Conversation

SanjayVas
Copy link
Member

@SanjayVas SanjayVas commented Jul 10, 2024 •
edited
Loading

This converts the Liquid Legions v2 Mill from a K8s Deployment to a CronJob.

BREAKING CHANGE: The Liquid Legions v2 Mill container images are now single jobs rather than daemons, where the --polling-interval option is replaced by a --grace-period option.
BREAKING CHANGE: The Liquid Legions v2 Mill daemon Deployment has been replaced by a CronJob.
BREAKING CHANGE: A CronJob scheduler Deployment must exist in each Duchy cluster with appropriate access to the K8s API in the cluster.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-mill-job branch 2 times, most recently from beaaf89 to 9e4b0a7 Compare July 10, 2024 20:56
kungfucraig
kungfucraig reviewed Jul 11, 2024
View reviewed changes
Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a document that describes how to roll this out?

Are we keeping the daemon images/configs until the cron has been successfully rolled out by our clients?

Reviewable status: 0 of 72 files reviewed, all discussions resolved

SanjayVas
SanjayVas commented Jul 11, 2024
View reviewed changes
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this PR is still a draft while I work on testing out the interaction between the cluster autoscaler and CronJobs.

Can you add a document that describes how to roll this out?

It'll be part of the release notes. It's not really different than any other change to our K8s object configs.

Are we keeping the daemon images/configs until the cron has been successfully rolled out by our clients?

No. As mentioned above, it's similar to other changes we push out regularly.

Reviewable status: 0 of 72 files reviewed, all discussions resolved

SanjayVas
SanjayVas commented Jul 11, 2024
View reviewed changes
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To clarify the above statement regarding keeping the daemon images: the new release will have the image be for a job rather than a daemon. Previous releases will still be a daemon.

Reviewable status: 0 of 72 files reviewed, all discussions resolved

@SanjayVas SanjayVas force-pushed the sanjayvas-mill-job branch 2 times, most recently from 7867995 to f58dbfa Compare July 15, 2024 18:00
@SanjayVas SanjayVas changed the base branch from main to sanjayvas-hmss-deployment-name July 16, 2024 22:35
@SanjayVas SanjayVas changed the title Convert Liquid Legions v2 Mill to CronJob. feat!: convert Liquid Legions v2 Mill to CronJob Jul 16, 2024
@SanjayVas
Copy link
Member Author

Depends on #1692

@SanjayVas SanjayVas marked this pull request as ready for review July 16, 2024 22:36
@SanjayVas SanjayVas changed the title feat!: convert Liquid Legions v2 Mill to CronJob feat!: enable horizontal autoscaling of Liquid Legions v2 Mill Jul 16, 2024
@SanjayVas SanjayVas force-pushed the sanjayvas-hmss-deployment-name branch from 9d36901 to 8760f1c Compare July 16, 2024 23:28
@SanjayVas
fix!: shorten overly long name for HMSS Mill Deployment
413200c 
The name is too long for the standard metadata name field.

BREAKING CHANGE: Renames a K8s Deployment in the dev configuration.
Base automatically changed from sanjayvas-hmss-deployment-name to main July 18, 2024 17:19
@SanjayVas SanjayVas changed the title feat!: enable horizontal autoscaling of Liquid Legions v2 Mill feat!: enable horizontal autoscaling of Liquid Legions v2 Mill via CronJobs Jul 19, 2024
@SanjayVas SanjayVas mentioned this pull request Jul 19, 2024
Merged
@SanjayVas
Copy link
Member Author

Dropping this in favor of #1697

@SanjayVas SanjayVas closed this Jul 22, 2024
@SanjayVas SanjayVas deleted the sanjayvas-mill-job branch July 22, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kungfucraig kungfucraig kungfucraig left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SanjayVas @wfa-reviewable @kungfucraig