Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target for exporting shareshuffle library as a Maven artifact. #1674

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

SanjayVas
Copy link
Member

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas force-pushed the sanjayvas-shareshuffle-maven branch from 4602916 to 7093942 Compare June 27, 2024 01:29
@SanjayVas
Copy link
Member Author

SanjayVas commented Jun 27, 2024

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this!

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)


src/main/kotlin/org/wfanet/measurement/eventdataprovider/shareshuffle/v2alpha/FulfillRequisitionRequestBuilder.kt line 168 at r1 (raw file):

    }

    private fun loadNativeLibrary() {

nit: Inline this in the init block or leave a TODO to move it to common JVM?

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 1 of 8 files reviewed, all discussions resolved (waiting on @kungfucraig)

a discussion (no related file):
I reworked this a bit to behave more like native TLS deps for grpc-java. There's a separate shareshuffle-native artifact that you can add as a runtime dependency. If it's found, the native library will be loaded from there. If not, it'll be loaded from your library path.

This gives a convenient way for anyone to use our prebuilt shared library if they desire. Otherwise they can compile it themselves (e.g. with a different libc) and include it in their library path.



src/main/kotlin/org/wfanet/measurement/eventdataprovider/shareshuffle/v2alpha/FulfillRequisitionRequestBuilder.kt line 168 at r1 (raw file):

Previously, kungfucraig (Craig Wright) wrote…

nit: Inline this in the init block or leave a TODO to move it to common JVM?

This is extracted to a function rather than having a comment over a block of code. It's a common readability pattern.

Copy link
Member

@kungfucraig kungfucraig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 8 files reviewed, all discussions resolved (waiting on @kungfucraig and @stevenwarejones)

a discussion (no related file):
Will follow up with a workflow to publish these artifacts on release.


Copy link
Collaborator

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 8 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @kungfucraig)

@SanjayVas SanjayVas force-pushed the sanjayvas-shareshuffle-maven branch from b7a5524 to d345535 Compare July 8, 2024 16:58
@SanjayVas SanjayVas enabled auto-merge (squash) July 8, 2024 16:59
@SanjayVas SanjayVas merged commit cc45f92 into main Jul 8, 2024
4 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-shareshuffle-maven branch July 8, 2024 17:29
SanjayVas added a commit that referenced this pull request Jul 15, 2024
SanjayVas added a commit that referenced this pull request Jul 16, 2024
ple13 pushed a commit that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants