-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add target for exporting shareshuffle library as a Maven artifact. #1674
Conversation
4602916
to
7093942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for doing this!
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SanjayVas)
src/main/kotlin/org/wfanet/measurement/eventdataprovider/shareshuffle/v2alpha/FulfillRequisitionRequestBuilder.kt
line 168 at r1 (raw file):
} private fun loadNativeLibrary() {
nit: Inline this in the init block or leave a TODO to move it to common JVM?
7093942
to
4768484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 of 8 files reviewed, all discussions resolved (waiting on @kungfucraig)
a discussion (no related file):
I reworked this a bit to behave more like native TLS deps for grpc-java. There's a separate shareshuffle-native
artifact that you can add as a runtime dependency. If it's found, the native library will be loaded from there. If not, it'll be loaded from your library path.
This gives a convenient way for anyone to use our prebuilt shared library if they desire. Otherwise they can compile it themselves (e.g. with a different libc) and include it in their library path.
src/main/kotlin/org/wfanet/measurement/eventdataprovider/shareshuffle/v2alpha/FulfillRequisitionRequestBuilder.kt
line 168 at r1 (raw file):
Previously, kungfucraig (Craig Wright) wrote…
nit: Inline this in the init block or leave a TODO to move it to common JVM?
This is extracted to a function rather than having a comment over a block of code. It's a common readability pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 8 of 8 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)
4768484
to
b7a5524
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 6 of 8 files reviewed, all discussions resolved (waiting on @kungfucraig and @stevenwarejones)
a discussion (no related file):
Will follow up with a workflow to publish these artifacts on release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 8 files at r2, 2 of 2 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @kungfucraig)
b7a5524
to
d345535
Compare
No description provided.