Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish common library as Maven artifact on release #258

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

SanjayVas
Copy link
Member

No description provided.

@wfa-reviewable
Copy link

This change is Reviewable

@SanjayVas SanjayVas changed the base branch from main to sanjayvas-native-deps June 28, 2024 01:07
@SanjayVas SanjayVas changed the title Sanjayvas maven Add maven coordinates for common library target Jun 28, 2024
@SanjayVas SanjayVas force-pushed the sanjayvas-maven branch 13 times, most recently from 29fa670 to 6bba2c4 Compare June 28, 2024 22:54
@SanjayVas SanjayVas changed the title Add maven coordinates for common library target Publish common library as Maven artifact on release Jun 28, 2024
@SanjayVas SanjayVas marked this pull request as ready for review June 28, 2024 22:55
@SanjayVas
Copy link
Member Author

CC @kungfucraig

We can publish other artifacts as needed. This is just the only one that the HMSS EDP library depends on.

@SanjayVas
Copy link
Member Author

This includes workarounds for bazelbuild/bazel#22919 and bazel-contrib/rules_jvm_external#1186.

Depends on #257.

Copy link
Contributor

@stevenwarejones stevenwarejones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

Base automatically changed from sanjayvas-native-deps to main July 1, 2024 17:21
@SanjayVas SanjayVas force-pushed the sanjayvas-maven branch 5 times, most recently from 4609819 to d52f2da Compare July 1, 2024 18:07
Copy link
Member Author

@SanjayVas SanjayVas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SanjayVas)

@SanjayVas SanjayVas enabled auto-merge (squash) July 1, 2024 18:08
@SanjayVas SanjayVas merged commit 133e38a into main Jul 1, 2024
3 checks passed
@SanjayVas SanjayVas deleted the sanjayvas-maven branch July 1, 2024 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants