Drag & Drop blocks feature

[geriux]

• Gutenberg PR -> [RNMobile] Drag & drop blocks feature WordPress/gutenberg#40424

What?

Introduces the drag & drop blocks feature to the native version of the editor.

Why?

This is the integration PR of the drag & drop blocks feature.

How?

The implementation details can be found at WordPress/gutenberg#40424.

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

Wanna run full suite of Android and iOS UI tests? Click here and 'Approve' CI job!

[geriux]

LGTM! I can't approve the PR but all good from my side ✅

[fluiddot]

@geriux looks like the E2E test failures are actual breakages 😭. I investigated further and at least on Android, it's related to the fact that the block's content is now wrapped with a View component. The text block queries look for an EditText children element of the block, which can't be found because of the wrapper View. It should be relatively easy to address the issue just by updating the queries so the EditText element could be found at any nested level.

Example

Current implementation

• XPath query: //android.view.ViewGroup[contains(@content-desc, "Paragraph Block. Row 2.")]/android.widget.EditText

EditText element is expected to be children of the block but at the first level.

Future implementation

• XPath query: //android.view.ViewGroup[contains(@content-desc, "Paragraph Block. Row 2.")]//android.widget.EditText (Note the change: / => //)

EditText element is expected to be children of the block but at any nested level.

---

I will work on applying this fix in the Gutenberg PR and check if the fix makes the CI jobs pass 🤞 .

[geriux]

I will work on applying this fix in the Gutenberg PR and check if the fix makes the CI jobs pass 🤞 .

Cool! Thanks for explaining the issue and fixing it! It looks like they passed now 🎉

[geriux]

Should we maybe run the full ones just to double check?

[fluiddot]

Should we maybe run the full ones just to double check?

Yeah, I'm going to trigger the full ones because there was one on iOS that was failing.

[fluiddot]

Regarding the failure of the iOS E2E test, I applied the fix in WordPress/gutenberg@7292638. I'm going to update the Gutenberg reference and trigger all PR checks again.

[fluiddot]

I will work on applying this fix in the Gutenberg PR and check if the fix makes the CI jobs pass 🤞 .

Cool! Thanks for explaining the issue and fixing it! It looks like they passed now 🎉

Yeah 🎊 ! Looks like the fix (WordPress/gutenberg@decf119) for the Android E2E tests worked.

[fluiddot]

@geriux Finally all PR checks have passed 🎊 , I'll proceed to merge the PRs.

[fluiddot]

Approved via WordPress/gutenberg#40424 (review).