Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Narrow blur on unmount to replaceable #1128

Merged
merged 7 commits into from
Jun 13, 2019
Merged

Narrow blur on unmount to replaceable #1128

merged 7 commits into from
Jun 13, 2019

Commits on Jun 13, 2019

  1. Pass isReplaceable via Context so RichText can blur 

    We need to have the RichText in a replaceable block blur on unmount
because it won't have the chance to do it on its componentDidUpdate.
    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    2670df8 View commit details
    Browse the repository at this point in the history

  2. Point to a branched GB hash

    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    a2c5d9d View commit details
    Browse the repository at this point in the history

  3. Declare isReplaceable's type

    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    08a8a49 View commit details
    Browse the repository at this point in the history

  4. Rename to an unstable, very goal-named name

    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    4cec0d1 View commit details
    Browse the repository at this point in the history

  5. Let RichText compute shouldBlurOnUnmount by its own

    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    4c2d660 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'release/1.7.0' into fix/narrow-blur-on-unmount-to-repla… 

    …ceable
    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    914f10f View commit details
    Browse the repository at this point in the history

  7. Point to the merged-to-release GB hash

    @hypest
    hypest committed Jun 13, 2019
    Configuration menu
    Copy the full SHA
    1ffac10 View commit details
    Browse the repository at this point in the history