Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Narrow blur on unmount to replaceable #1128

Merged
merged 7 commits into from
Jun 13, 2019

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Jun 13, 2019

Fixes #1126

Gutenberg PR: WordPress/gutenberg#16151

To test:

  1. Remove all the content
  2. Insert an image
  3. Remove the image
  4. Ensure there's no crash

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

We need to have the RichText in a replaceable block blur on unmount
because it won't have the chance to do it on its componentDidUpdate.
@hypest hypest added this to the v1.7 milestone Jun 13, 2019
Copy link
Contributor

@marecar3 marecar3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :)

@SergioEstevao
Copy link
Contributor

Working fine on iOS too.

@hypest hypest merged commit fda80a8 into release/1.7.0 Jun 13, 2019
@hypest hypest deleted the fix/narrow-blur-on-unmount-to-replaceable branch June 13, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants