This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Add useURLSession configuration to pass to WordPressKit
#836
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so we have access to the `useURLSession` property of the API classes.
This will allow clients that do no need access to WordPressKit (i.e. WooCommerce) to explicitly depend only on WordPressAuthenticator and still configure whether to use `URLSession`.
1 task
crazytonyli
reviewed
Feb 21, 2024
| useEnterEmailAddressAsStepValueForGetStartedVC: Bool = false, | ||
| enableSiteAddressLoginOnlyInPrologue: Bool = false | ||
| enableSiteAddressLoginOnlyInPrologue: Bool = false, | ||
| useURLSession: Bool = false |
There was a problem hiding this comment.
The useURLSession configuration is a global configuration, using it in an initialiser feels weird to me...
Also, we'll soon (maybe in a couple of weeks) deprecate useURLSession and remove Alamofire from WordPressKit. Maybe not worth adding it to another framework?
There was a problem hiding this comment.
Fair enough. I'm okay to wait, in particular because the useURLSession deprecation should be very near: wordpress-mobile/WordPressKit-iOS#736
auto-merge was automatically disabled
February 23, 2024 02:21
Pull request was closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow clients that do no need access to WordPressKit (i.e. WooCommerce) to explicitly depend only on WordPressAuthenticator and still configure whether to use
URLSession.See it in use in woocommerce/woocommerce-ios#12063
For context: I discovered this possibility while looking around the apps and the libraries searching for ways to redistribute concerns. I wanted to know how many of the WordPressKit APIs Woo used, go I grepped
import WordPressKit. I found a single usage, which this PR plus woocommerce/woocommerce-ios#12063 remove.CHANGELOG.mdif necessary.