Skip to content

Conversation

mokagio
Copy link
Contributor

@mokagio mokagio commented Feb 21, 2024

Description

Building on top of wordpress-mobile/WordPressAuthenticator-iOS#836, this removes the implicit dependency on WordPressKit. That is, it removes the one import it had and removes it from Podfile.

This is not a game changer, we still depend on the library implicitly via WordPressAuthenticator. But I think it's a little win. One less library to look at in the Podfile and to be aware of.

Testing instructions

I run the app with breakpoints to verify the useURLSession value is passed along from Woo to Authenticator. The only flows that trigger WordPressKit usages are authentication ones (which is obvious given Authenticator is the the one depending on it.


  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. — N.A.

@dangermattic
Copy link
Collaborator

dangermattic commented Feb 21, 2024

1 Warning
⚠️ This PR is assigned to the milestone 17.5. This milestone is due in less than 2 days.
Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by 🚫 Danger

@mokagio mokagio added this to the 17.5 milestone Feb 21, 2024
@mokagio mokagio added the category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc. label Feb 21, 2024
@mokagio mokagio requested a review from crazytonyli February 21, 2024 10:53
@wpmobilebot
Copy link
Collaborator

WooCommerce iOS📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.

App NameWooCommerce iOS WooCommerce iOS
Build Numberpr12063-710c1aa
Version17.4
Bundle IDcom.automattic.alpha.woocommerce
Commit710c1aa
App Center BuildWooCommerce - Prototype Builds #8112
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@mokagio
Copy link
Contributor Author

mokagio commented Feb 23, 2024

@mokagio mokagio closed this Feb 23, 2024
@mokagio mokagio deleted the mokagio/remove-explicit-wordpresskit-dependency branch February 23, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category: tooling Anything that involves building & maintaining the project, including scripts, `Fastfile`, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants