Remove the explicit dependency on WordPressKit #12063
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Building on top of wordpress-mobile/WordPressAuthenticator-iOS#836, this removes the implicit dependency on WordPressKit. That is, it removes the one
import
it had and removes it fromPodfile
.This is not a game changer, we still depend on the library implicitly via WordPressAuthenticator. But I think it's a little win. One less library to look at in the
Podfile
and to be aware of.Testing instructions
I run the app with breakpoints to verify the
useURLSession
value is passed along from Woo to Authenticator. The only flows that trigger WordPressKit usages are authentication ones (which is obvious given Authenticator is the the one depending on it.RELEASE-NOTES.txt
if necessary. — N.A.