Upgrade to Emscripten 3.1.26 single-threaded #206
Closed
+3
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Disabling -Werror for now, until boost is updated or we vendor boost, or use system installed boost.
NorrinRadd
changed the title
woodser
reviewed
May 15, 2024
| @@ -280,7 +279,7 @@ EMCC_LINKER_FLAGS_BASE | |||
| # unsure if the -I...boost..include is necessary here due to include above | |||
| # TODO? does EXPORT_NAME need to be the same for both targets? (or should it be set per-target with …_WASM, …_ASMJS?) | |||
|
|
|||
| "-Wall -Werror -Wl,--allow-undefined -std=c++14 -Oz \ | |||
| "-Wall -Wl,--allow-undefined -std=c++14 -Oz \ | |||
There was a problem hiding this comment.
I had to add this change when I was testing recent versions of emscripten, but maybe the change can be removed with 3.1.26, so -Werror is included?
| @@ -241,7 +241,6 @@ set( | |||
| ${MONERO_PROJECT_SRC}/wallet/message_store.cpp | |||
| ${MONERO_PROJECT_SRC}/wallet/message_transporter.cpp | |||
| ${MONERO_PROJECT_SRC}/wallet/node_rpc_proxy.cpp | |||
| ${MONERO_PROJECT_SRC}/wallet/wallet_rpc_payments.cpp | |||
There was a problem hiding this comment.
This file is present in the release-v0.18 branch, which is what monero-ts is built on: https://github.com/monero-project/monero/blob/release-v0.18/src/wallet/wallet_rpc_payments.cpp
| @@ -34,7 +34,7 @@ namespace epee | |||
| bool is_connected(bool *ssl = NULL) override; | |||
| bool invoke(const boost::string_ref uri, const boost::string_ref method, const boost::string_ref body, std::chrono::milliseconds timeout, const http_response_info** ppresponse_info = NULL, const fields_list& additional_params = fields_list()) override; | |||
| bool invoke_get(const boost::string_ref uri, std::chrono::milliseconds timeout, const string& body = string(), const http_response_info** ppresponse_info = NULL, const fields_list& additional_params = fields_list()) override; | |||
| bool invoke_post(const boost::string_ref uri, const string& body, std::chrono::milliseconds timeout, const http_response_info** ppresponse_info = NULL, const fields_list& additional_params = fields_list()) override; | |||
| bool invoke_post(const boost::string_ref uri, const string& body, std::chrono::milliseconds timeout, const http_response_info** ppresponse_info = NULL, const fields_list& additional_params = fields_list()); | |||
There was a problem hiding this comment.
I think this change is not necessary when built against the release-v0.18 branch, so can be removed.
|
I've made the changes to update to 3.1.26 on this PR: #224 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially resolves #144