Update emscripten [2 XMR]

[woodser]

This issue requests updating the build to use the latest version of emscripten.

The library is currently using version 3.1.10.

[github-actions]

There is a bounty on this issue. The amount is in the title. The reward will be awarded to the first person or group of people who resolve this issue.

If you are starting to work on this bounty, please write a comment so that we can assign the issue to you. We expect contributors to provide a PR in a reasonable timeframe or, in case of an extensive work, updates on their progress. We will unassign the issue if we feel the assignee is not responsive or has abandoned the task.

Read the full conditions and details of the bounty system.

[woodser]

See the work in progress draft PR as a starting point: #192

[NorrinRadd]

I will take this. Please assign.

[woodser]

Great, I've assigned to you @NorrinRadd

[woodser]

I forgot to mention, the upgrade should not use multithreading or pthreads, like I was experimenting with in the draft PR. Instead, it should still be single-threaded.

[NorrinRadd]

I have all the builds working except for with the new version of emscripten.

To future-proof it, threads seem important. Threads were disabled somehow with the previous version? @woodser

[woodser]

I have all the builds working except for with the new version of emscripten.

Great to hear.

To future-proof it, threads seem important. Threads were disabled somehow with the previous version? @woodser

Yes agreed, we do want threads, but it requires additional configuration to make it work in the browser. So I'd prefer we complete the upgrade to the latest version of emscripten first, to avoid breaking dependent applications.

And then with the latest version of emscripten, we can add threading support.

[woodser]

But if you can get it working with threads (since the new emscripten seems to really prefer that), then that's great progress, and we could attempt to remove threads after.

[NorrinRadd]

yeah the monero project seems to require threads: https://github.com/monero-project/monero/blob/master/src/wallet/node_rpc_proxy.h#L32

[woodser]

This project builds and runs now against monero-project without pthreads, so it's not required that multiple threads are enabled, even with the imports.

You should be able to confirm the working build with emscripten 3.1.10.

[NorrinRadd]

@woodser i got it to build with the latest emscripten. Attempting to run tests now. Your npm test requires that testnet be fully synced and not pruned?

[NorrinRadd]

@woodser PR submitted

[NorrinRadd]

Along with #206,

• isolated the single-threaded build errors down to the build_boost_emscripten phase.
• downgraded boost to a version that was out around when emscripten 3.1.26 (last working version) was out >> still fails. Therefore the culprit seems to be emscripten.
• sent a bug report to emscripten regarding the newer versions: Emscripten arm64 > 3.1.26 cannot build certain libboost libraries emscripten-core/emscripten#21793 Hopefully can get some transaction soon.

[NorrinRadd]

@woodser Update from emscripten team: They're of the belief that this is deliberate from Boost; that if certain classes are used, then multi-threading must be enabled. It also seems like it was an error that Emscripten < 3.1.26 was avoiding this somehow, but I have not received a reply from them on that yet.

ignoring nonexistent directory "/Users/user/code/emsdk/upstream/emscripten/cache/sysroot/include/ wasm32-emscripten/c++/v1"
ignoring nonexistent directory "/Users/user/code/emsdk/upstream/emscripten/cache/sysroot/include/ wasm32-emscripten"
#include "..." search starts here:
#include <...> search starts here:
 .
 /Users/user/code/emsdk/upstream/emscripten/cache/sysroot/include/fakesdl
 /Users/user/code/emsdk/upstream/emscripten/cache/sysroot/include/compat
 /Users/user/code/emsdk/upstream/emscripten/cache/sysroot/include/c++/v1
 /Users/user/code/emsdk/upstream/lib/clang/19/include
 /Users/user/code/emsdk/upstream/emscripten/cache/sysroot/include
End of search list.
In file included from libs/thread/src/pthread/thread.cpp:9:
In file included from ./boost/thread/detail/config.hpp:13:
In file included from ./boost/thread/detail/platform.hpp:17:
./boost/config/requires_threads.hpp:29:4: error: "Threading support unavaliable: it has been      explicitly disabled with BOOST_DISABLE_THREADS"
   29 | #  error "Threading support unavaliable: it has been explicitly disabled with             BOOST_DISABLE_THREADS"
      |    ^   
1 error generated.

You can check the first PR (regarding multi-threading support) that it has been updated with a fix for the shared buffer issue, as well as a web worker issue. The remainder of the work seems to be updating monero-ts to actually use the web workers.

[woodser]

Thanks for the update. Maybe multithreading is the way forward, though will require changes to any downstream dependents.

[NorrinRadd]

@woodser, Have you seen the update that denotes that Emscripten 3.1.26 can be used? It gets the upgrade part of the way there.

…

On Mon, Apr 22, 2024 at 9:44 AM woodser ***@***.***> wrote: Thanks for the update. Maybe multithreading is the way forward, though will require changes to any downstream dependents. — Reply to this email directly, view it on GitHub <#144 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHNEHQCCRP3WS667Y5ZET3Y6TEYTAVCNFSM6AAAAAA5RLGSOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRYHAZTENJUHE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[woodser]

Yes, that's definitely a step in the right direction. I'll need to play with it, and either we update to that intermediately or go for the big update.

[NorrinRadd]

@woodser please what is the update? emscripten has been updated as far as possible. Please evaluate this pull request.

[woodser]

Ideally we can update to the latest emscripten, built with pthreads, but with pthreads disabled as a final step in the linker flags, before a major update to support real threading.

It's limited use to update halfway.

[woodser]

Resolved by @mainnet-pat in #258