Skip to content

Fix report skipped status#6300

Merged
lafriks merged 2 commits into
woodpecker-ci:mainfrom
6543-forks:fix-skipped-step-status
Mar 22, 2026
Merged

Fix report skipped status#6300
lafriks merged 2 commits into
woodpecker-ci:mainfrom
6543-forks:fix-skipped-step-status

Conversation

@6543

@6543 6543 commented Mar 22, 2026

Copy link
Copy Markdown
Member
image

i first suspected my logic change as initially used the calcled as signal for skiped steps.
but i just forgot to move the struct change alongside grpc stuff ...

... now tested locally multible times to not mess up again

regression of #6295

@6543 6543 added skip-changelog regression fix a bug that was not released yet labels Mar 22, 2026
@6543 6543 requested a review from lafriks March 22, 2026 20:25
@lafriks lafriks merged commit 1a94f05 into woodpecker-ci:main Mar 22, 2026
7 checks passed
@codecov

codecov Bot commented Mar 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 54.16667% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.08%. Comparing base (6d60849) to head (4fd8525).
⚠️ Report is 19 commits behind head on main.

Files with missing lines Patch % Lines
rpc/proto/woodpecker.pb.go 0.00% 5 Missing ⚠️
server/pipeline/step_status.go 76.47% 3 Missing and 1 partial ⚠️
agent/rpc/client_grpc.go 0.00% 1 Missing ⚠️
server/rpc/server.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6300      +/-   ##
==========================================
+ Coverage   32.43%   33.08%   +0.64%     
==========================================
  Files         420      420              
  Lines       28320    28341      +21     
==========================================
+ Hits         9185     9376     +191     
+ Misses      18286    18103     -183     
- Partials      849      862      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543

6543 commented Mar 22, 2026

Copy link
Copy Markdown
Member Author

thx!

@6543 6543 deleted the fix-skipped-step-status branch March 22, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

regression fix a bug that was not released yet skip-changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants