Report skipped step state as soon as it's determined#6295
Merged
6543 merged 9 commits intoMar 22, 2026
Conversation
This was referenced Mar 22, 2026
6543
commented
Mar 22, 2026
lafriks
approved these changes
Mar 22, 2026
lafriks
left a comment
Contributor
There was a problem hiding this comment.
Apart from lint failures LGTM
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6295 +/- ##
==========================================
+ Coverage 32.43% 33.06% +0.63%
==========================================
Files 420 420
Lines 28320 28333 +13
==========================================
+ Hits 9185 9368 +183
+ Misses 18286 18103 -183
- Partials 849 862 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
regression is fixed with #6300 (also code simplified and more tests) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently we mark all steps that are pending after a workflow finished as skipped.
this is wrong!
as we know when we decide if a step is skipped we now just signal that back the server.
this pull also rewords the pipeline/state.State to match our terminology