Skip to content

Report skipped step state as soon as it's determined#6295

Merged
6543 merged 9 commits into
woodpecker-ci:mainfrom
6543-forks:rename-pipeline-state-add-skipped
Mar 22, 2026
Merged

Report skipped step state as soon as it's determined#6295
6543 merged 9 commits into
woodpecker-ci:mainfrom
6543-forks:rename-pipeline-state-add-skipped

Conversation

@6543

@6543 6543 commented Mar 22, 2026

Copy link
Copy Markdown
Member

currently we mark all steps that are pending after a workflow finished as skipped.

this is wrong!

as we know when we decide if a step is skipped we now just signal that back the server.

this pull also rewords the pipeline/state.State to match our terminology

@6543 6543 added enhancement improve existing features wip engine change how the pipeline engine works labels Mar 22, 2026
Comment thread agent/tracer.go Outdated
@6543 6543 changed the title WIP: Forward skip state (title is wip) Forward skipped step state asap it is known Mar 22, 2026
@6543 6543 removed the wip label Mar 22, 2026
@6543 6543 requested a review from qwerty287 March 22, 2026 13:16
@6543 6543 marked this pull request as ready for review March 22, 2026 13:16

@lafriks lafriks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from lint failures LGTM

@6543 6543 merged commit 513011d into woodpecker-ci:main Mar 22, 2026
7 checks passed
@6543 6543 deleted the rename-pipeline-state-add-skipped branch March 22, 2026 17:21
@qwerty287 qwerty287 changed the title Forward skipped step state asap it is known Forward skipped step state once it's known Mar 22, 2026
@woodpecker-bot woodpecker-bot mentioned this pull request Mar 22, 2026
1 task
@codecov

codecov Bot commented Mar 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 37.73585% with 33 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.06%. Comparing base (6d60849) to head (df9a6b3).
⚠️ Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
agent/tracer.go 0.00% 20 Missing ⚠️
server/pipeline/step_status.go 60.00% 5 Missing and 1 partial ⚠️
pipeline/tracing/tracer.go 0.00% 4 Missing ⚠️
pipeline/runtime/executor.go 78.57% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6295      +/-   ##
==========================================
+ Coverage   32.43%   33.06%   +0.63%     
==========================================
  Files         420      420              
  Lines       28320    28333      +13     
==========================================
+ Hits         9185     9368     +183     
+ Misses      18286    18103     -183     
- Partials      849      862      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543 6543 mentioned this pull request Mar 22, 2026
@6543

6543 commented Mar 22, 2026

Copy link
Copy Markdown
Member Author

regression is fixed with #6300 (also code simplified and more tests)

@woodpecker-bot woodpecker-bot mentioned this pull request Apr 1, 2026
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 15, 2026
1 task
@6543 6543 changed the title Forward skipped step state once it's known Report skipped step state as soon as it's determined Apr 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

engine change how the pipeline engine works enhancement improve existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants