Enable crons if created via CLI

cli/repo/cron/cron_add.go

@@ -47,6 +47,11 @@ var cronCreateCmd = &cli.Command{
 			Usage:    "cron schedule",
 			Required: true,
 		},
+		&cli.BoolFlag{
+			Name:  "enabled",
+			Usage: "whether cron is enabled",
+			Value: true,
+		},
 		common.FormatFlag(tmplCronList, true),
 	},
 }
@@ -58,6 +63,7 @@ func cronCreate(ctx context.Context, c *cli.Command) error {
 		schedule         = c.String("schedule")
 		repoIDOrFullName = c.String("repository")
 		format           = c.String("format") + "\n"
+		enabled          = c.Bool("enabled")
 	)
 	if repoIDOrFullName == "" {
 		repoIDOrFullName = c.Args().First()
@@ -77,6 +83,7 @@ func cronCreate(ctx context.Context, c *cli.Command) error {
 		Name:     cronName,
 		Branch:   branch,
 		Schedule: schedule,
+		Enabled:  enabled,
 	}
 	cron, err = client.CronCreate(repoID, cron)
 	if err != nil {

cli/repo/cron/cron_update.go

@@ -50,6 +50,11 @@ var cronUpdateCmd = &cli.Command{
 			Name:  "schedule",
 			Usage: "cron schedule",
 		},
+		&cli.BoolFlag{
+			Name:  "enabled",
+			Usage: "whether cron is enabled",
+			Value: true,
+		},
 		common.FormatFlag(tmplCronList, true),
 	},
 }
@@ -62,6 +67,7 @@ func cronUpdate(ctx context.Context, c *cli.Command) error {
 		branch           = c.String("branch")
 		schedule         = c.String("schedule")
 		format           = c.String("format") + "\n"
+		enabled          = c.Bool("enabled")
 	)
 	if repoIDOrFullName == "" {
 		repoIDOrFullName = c.Args().First()
@@ -79,6 +85,7 @@ func cronUpdate(ctx context.Context, c *cli.Command) error {
 		Name:     jobName,
 		Branch:   branch,
 		Schedule: schedule,
+		Enabled:  enabled,
 	}
 	cron, err = client.CronUpdate(repoID, cron)
 	if err != nil {

server/api/cron.go

@@ -15,6 +15,7 @@
 package api
 
 import (
+	"errors"
 	"net/http"
 	"strconv"
 	"time"
@@ -28,6 +29,7 @@ import (
 	"go.woodpecker-ci.org/woodpecker/v3/server/pipeline"
 	"go.woodpecker-ci.org/woodpecker/v3/server/router/middleware/session"
 	"go.woodpecker-ci.org/woodpecker/v3/server/store"
+	"go.woodpecker-ci.org/woodpecker/v3/server/store/types"
 )
 
 // GetCron
@@ -153,7 +155,11 @@ func PostCron(c *gin.Context) {
 	}
 
 	if err := _store.CronCreate(cron); err != nil {
-		c.String(http.StatusInternalServerError, "Error inserting cron %q. %s", in.Name, err)
+		if errors.Is(err, types.ErrUniqueExists) {
+			c.String(http.StatusConflict, "cron with this exists for this repo already")
+		} else {
+			c.String(http.StatusInternalServerError, "Error inserting cron %q. %s", in.Name, err)
+		}
 		return
 	}
 	c.JSON(http.StatusOK, cron)

server/store/datastore/cron.go

@@ -15,16 +15,22 @@
 package datastore
 
 import (
+	"strings"
+
 	"xorm.io/builder"
 
 	"go.woodpecker-ci.org/woodpecker/v3/server/model"
+	"go.woodpecker-ci.org/woodpecker/v3/server/store/types"
 )
 
 func (s storage) CronCreate(cron *model.Cron) error {
 	if err := cron.Validate(); err != nil {
 		return err
 	}
 	_, err := s.engine.Insert(cron)
+	if err != nil && (strings.HasPrefix(err.Error(), "UNIQUE constraint failed") || strings.HasPrefix(err.Error(), "pq: duplicate key value violates unique constraint") || strings.Contains(err.Error(), "Duplicate entry")) {
+		return types.ErrUniqueExists
+	}
 	return err
 }
 

server/store/datastore/cron_test.go

@@ -21,6 +21,7 @@ import (
 	"github.com/stretchr/testify/assert"
 
 	"go.woodpecker-ci.org/woodpecker/v3/server/model"
+	"go.woodpecker-ci.org/woodpecker/v3/server/store/types"
 )
 
 func TestCronCreate(t *testing.T) {
@@ -33,7 +34,7 @@ func TestCronCreate(t *testing.T) {
 	assert.NotEqualValues(t, 0, cron1.ID)
 
 	// cannot insert cron job with same repoID and title
-	assert.Error(t, store.CronCreate(cron1))
+	assert.ErrorIs(t, types.ErrUniqueExists, store.CronCreate(cron1))
 
 	oldID := cron1.ID
 	assert.NoError(t, store.CronDelete(repo, oldID))

server/store/types/errors.go

@@ -14,6 +14,11 @@
 
 package types
 
-import "database/sql"
+import (
+	"database/sql"
+	"errors"
+)
 
 var RecordNotExist = sql.ErrNoRows
+
+var ErrUniqueExists = errors.New("unique constraint failed")

woodpecker-go/woodpecker/types.go

@@ -257,6 +257,7 @@ type (
 		Schedule  string `json:"schedule"`
 		Created   int64  `json:"created"`
 		Branch    string `json:"branch"`
+		Enabled   bool   `json:"enabled"`
 	}
 
 	// PipelineOptions is the JSON data for creating a new pipeline.