Skip to content

Enable crons if created via CLI#6228

Merged
6543 merged 11 commits into
woodpecker-ci:mainfrom
qwerty287:crons-cli
Mar 18, 2026
Merged

Enable crons if created via CLI#6228
6543 merged 11 commits into
woodpecker-ci:mainfrom
qwerty287:crons-cli

Conversation

@qwerty287

Copy link
Copy Markdown
Contributor

Crons were not enabled if created via CLI. fixes #6218 (reply in thread)

Also improve the error message if a cron with the same name exists already. Previously a 500 was returned, now a 409 Conflict.

@qwerty287 qwerty287 requested a review from a team March 10, 2026 15:51
@qwerty287 qwerty287 added the bug Something isn't working label Mar 10, 2026
@woodpecker-bot

woodpecker-bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Surge PR preview deployment was removed

@codecov

codecov Bot commented Mar 10, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.56%. Comparing base (6136301) to head (1148f63).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
server/api/cron.go 0.00% 5 Missing ⚠️
cli/repo/cron/cron_add.go 0.00% 2 Missing ⚠️
cli/repo/cron/cron_update.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6228      +/-   ##
==========================================
- Coverage   32.56%   32.56%   -0.01%     
==========================================
  Files         418      418              
  Lines       28160    28170      +10     
==========================================
+ Hits         9170     9173       +3     
- Misses      18143    18150       +7     
  Partials      847      847              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread server/api/cron.go Outdated
@6543 6543 added the cli label Mar 12, 2026
Comment thread server/store/datastore/cron.go Outdated
Comment thread server/api/cron.go Outdated
Comment thread server/store/datastore/cron.go Outdated
Comment thread server/store/datastore/cron_test.go Outdated
Comment thread server/store/types/errors.go Outdated
Co-authored-by: 6543 <6543@obermui.de>
@6543

6543 commented Mar 18, 2026

Copy link
Copy Markdown
Member

I have a followup that does wrapInsert like wrapGet etc ... but it will colide with your sol currently .... will ack this and then streamline it in a new pull 🪨

Comment thread server/api/cron.go Outdated
@6543 6543 merged commit 9fb5d4d into woodpecker-ci:main Mar 18, 2026
8 of 9 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Mar 18, 2026
1 task
@qwerty287 qwerty287 deleted the crons-cli branch March 19, 2026 06:36
@6543

6543 commented Mar 19, 2026

Copy link
Copy Markdown
Member

@qwerty287 i did #6259

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cli

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants