Skip to content

Report status for detached steps and services#6039

Merged
6543 merged 12 commits into
woodpecker-ci:mainfrom
6543-forks:detached-or-service-steps_report-back-too
Feb 7, 2026
Merged

Report status for detached steps and services#6039
6543 merged 12 commits into
woodpecker-ci:mainfrom
6543-forks:detached-or-service-steps_report-back-too

Conversation

@6543

@6543 6543 commented Jan 28, 2026

Copy link
Copy Markdown
Member
image image image

close #6033
resolve #2831

@6543 6543 added bug Something isn't working engine change how the pipeline engine works labels Jan 28, 2026
@codecov

codecov Bot commented Jan 28, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 64 lines in your changes missing coverage. Please review.
✅ Project coverage is 31.66%. Comparing base (fe9db66) to head (48d2ee4).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/pipeline.go 0.00% 35 Missing ⚠️
pipeline/backend/docker/docker.go 0.00% 25 Missing ⚠️
pipeline/backend/local/local.go 0.00% 3 Missing ⚠️
pipeline/backend/dummy/dummy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6039      +/-   ##
==========================================
- Coverage   31.71%   31.66%   -0.05%     
==========================================
  Files         420      420              
  Lines       28378    28413      +35     
==========================================
- Hits         8999     8996       -3     
- Misses      18559    18596      +37     
- Partials      820      821       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543

6543 commented Jan 28, 2026

Copy link
Copy Markdown
Member Author

TODO: restructure pipeline/*.go to use submodules

  • pipeline/error.go -> pipeline/errors/...
  • pipeline/pipeline.go#Runtime -> pipeline/runtime/runtime.go
  • pipeline/pipeline.go#execAll -> pipeline/runtime/executor.go
  • pipeline/shutdown.go -> pipeline/runtime/shutdown.go
  • pipeline/logger.go ->pipeline/logging
  • pipeline/tracer.go -> pipeline/tracing
  • X -> state/state.go?
  • ...

@anbraten

Copy link
Copy Markdown
Member

I would argue detached steps and services should let a pipeline fail. For example if you are testing a database / woodpecker server in some kind of integration test if they crash or fail the pipeline should be marked as failed as well. Users could still use "/bin/mytool || exit 0" if there service is likely to fail and should be ignored

@6543

6543 commented Jan 29, 2026

Copy link
Copy Markdown
Member Author

in this regards there is also the option to ignore errors...

@6543

6543 commented Jan 29, 2026

Copy link
Copy Markdown
Member Author

I'll test to see what a common case will do right now (mariadb & postgress as db)

@6543

6543 commented Jan 30, 2026

Copy link
Copy Markdown
Member Author
image well needs more work on that front ...

@6543

6543 commented Jan 30, 2026

Copy link
Copy Markdown
Member Author

Now

expl. failing services and detached

image ## normal have them succeed image

@6543

6543 commented Jan 30, 2026

Copy link
Copy Markdown
Member Author
5:42PM ERR agent/rpc/client_grpc.go:181 > grpc error: wait(): code: Unknown error="rpc error: code = Unknown desc = workflow finished with error "                                                 
5:42PM ERR agent/runner.go:112 > server returned unexpected err while waiting for workflow to finish run error="rpc error: code = Unknown desc = workflow finished with error " pipeline=129 repo=test/test-bash-ci workflow_id=129  

fixed by 4e5d5db

@6543 6543 force-pushed the detached-or-service-steps_report-back-too branch from 37b7e19 to 26c38ed Compare February 5, 2026 22:20
@6543 6543 marked this pull request as ready for review February 6, 2026 04:22
@6543 6543 mentioned this pull request Feb 6, 2026
@6543 6543 requested a review from a team February 6, 2026 12:16
@6543

6543 commented Feb 6, 2026

Copy link
Copy Markdown
Member Author

the approach how it's done is not the simplest code ... but I would like to move refactoring that stuff in a new pull after #6073 got merged witch is based on this pull :)

Comment thread pipeline/backend/docker/docker.go Outdated
6543 and others added 2 commits February 6, 2026 23:54
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>

@qwerty287 qwerty287 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine as well, but also untested.

@6543 6543 merged commit 904a406 into woodpecker-ci:main Feb 7, 2026
7 of 9 checks passed
@6543 6543 deleted the detached-or-service-steps_report-back-too branch February 7, 2026 08:18
@woodpecker-bot woodpecker-bot mentioned this pull request Feb 7, 2026
1 task
Comment thread pipeline/pipeline.go
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Feb 9, 2026
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 1, 2026
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 15, 2026
1 task
@6543 6543 changed the title Detached or service steps report back too Report status for detached steps and services Apr 19, 2026
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working engine change how the pipeline engine works

Projects

None yet

Development

Successfully merging this pull request may close these issues.

services / detached steps dont report backe if they end early Service step doesn't change its status

3 participants