Report status for detached steps and services#6039
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #6039 +/- ##
==========================================
- Coverage 31.71% 31.66% -0.05%
==========================================
Files 420 420
Lines 28378 28413 +35
==========================================
- Hits 8999 8996 -3
- Misses 18559 18596 +37
- Partials 820 821 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
TODO: restructure pipeline/*.go to use submodules
|
|
I would argue detached steps and services should let a pipeline fail. For example if you are testing a database / woodpecker server in some kind of integration test if they crash or fail the pipeline should be marked as failed as well. Users could still use "/bin/mytool || exit 0" if there service is likely to fail and should be ignored |
|
in this regards there is also the option to ignore errors... |
|
I'll test to see what a common case will do right now (mariadb & postgress as db) |
fixed by 4e5d5db |
37b7e19 to
26c38ed
Compare
|
the approach how it's done is not the simplest code ... but I would like to move refactoring that stuff in a new pull after #6073 got merged witch is based on this pull :) |
Co-authored-by: qwerty287 <80460567+qwerty287@users.noreply.github.com>
qwerty287
left a comment
There was a problem hiding this comment.
Seems fine as well, but also untested.
was missed in woodpecker-ci#6039



close #6033
resolve #2831