Skip to content

Don't propagate workflow error from agent back to agent#6056

Merged
6543 merged 10 commits into
woodpecker-ci:mainfrom
6543-forks:queue-dont-propagate-worklow-error-from-agent-back-to-agent
Feb 6, 2026
Merged

Don't propagate workflow error from agent back to agent#6056
6543 merged 10 commits into
woodpecker-ci:mainfrom
6543-forks:queue-dont-propagate-worklow-error-from-agent-back-to-agent

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Feb 2, 2026

we currently inject errors from workflows back to the queue. this is needed for things that should run in case an error occur.
But we should not report it back as queue error!

with this we wrap all external errors in an own error type so we can filter the out

before

image ## after image

@6543 6543 added the bug Something isn't working label Feb 2, 2026
@6543 6543 added the server label Feb 2, 2026
@6543 6543 force-pushed the queue-dont-propagate-worklow-error-from-agent-back-to-agent branch from a47aee4 to dd35740 Compare February 5, 2026 21:16
@6543 6543 force-pushed the queue-dont-propagate-worklow-error-from-agent-back-to-agent branch from dd35740 to 6ba1a46 Compare February 5, 2026 21:17
Comment thread server/rpc/rpc.go Outdated
@6543 6543 requested a review from a team February 5, 2026 21:19
@codecov

This comment was marked as off-topic.

@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 5, 2026

updated description with screenshot of logs before and after :)

Comment thread server/queue/fifo.go Outdated
6543 added a commit to 6543-forks/woodpecker that referenced this pull request Feb 5, 2026
@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 5, 2026

moved it into queue implementation only ...

Comment thread server/queue/fifo.go
Comment thread server/queue/fifo.go
@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 5, 2026

ok finally it's ready for review again 😅

Copy link
Copy Markdown
Contributor

@qwerty287 qwerty287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but also untested from my side.

The error is still visible in UI I think?

@qwerty287 qwerty287 changed the title Queue dont propagate worklow error from agent back to agent Don't propagate workflow error from agent back to agent Feb 6, 2026
@6543
Copy link
Copy Markdown
Member Author

6543 commented Feb 6, 2026

yes it is still handled and visible just not back propagated :D

as i touch that part of the code I'm certain ... still did a test on my side:
image

@6543 6543 merged commit 06818ee into woodpecker-ci:main Feb 6, 2026
9 checks passed
@6543 6543 deleted the queue-dont-propagate-worklow-error-from-agent-back-to-agent branch February 6, 2026 11:22
@woodpecker-bot woodpecker-bot mentioned this pull request Feb 6, 2026
1 task
@6543 6543 mentioned this pull request Feb 6, 2026
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 1, 2026
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 15, 2026
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Apr 27, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants