Support for file changes in Bitbucket Cloud#5730
Conversation
|
Thanks! Looks very good already. Could you check the formatting? https://ci.woodpecker-ci.org/repos/3780/pipeline/29586/16 And a question: How does that work with pull requests? |
|
@qwerty287 thanks for the heads-up, I fixed the formatting of the docs. For pull-requests the source commit is set as Pipeline Commit: woodpecker/server/forge/bitbucket/convert.go Lines 167 to 169 in 300e2a0 and so it will work the same as the Commit Hook as the diffstat is loaded after parsing the Hook content. I just tested it on my instance and everything worked as expected. |
|
OK, but for PRs it should load the changes for the full PR. So all commits together. That's how the other forges work. |
…destination branch
|
@qwerty287 Good catch. I've updated the PR so that it lists all changes between the source & destination branch using the diffstat API. |
qwerty287
left a comment
There was a problem hiding this comment.
Thanks. Seems good so far, just a simple question
|
Surge PR preview deployment was removed |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5730 +/- ##
==========================================
- Coverage 21.48% 21.46% -0.03%
==========================================
Files 428 428
Lines 38550 38597 +47
==========================================
Hits 8283 8283
- Misses 29503 29549 +46
- Partials 764 765 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This pull-request implements the
when.pathfilter for Bitbucket Cloud by requesting the changed files for a commit when a/api/hookis received.Similar to #5205, but for the Bitbucket Cloud forge.