Skip to content

Support for pull request file changes in bitbucketdatacenter#5205

Merged
anbraten merged 5 commits into
woodpecker-ci:mainfrom
henkka:bb-pr-changes
Jun 12, 2025
Merged

Support for pull request file changes in bitbucketdatacenter#5205
anbraten merged 5 commits into
woodpecker-ci:mainfrom
henkka:bb-pr-changes

Conversation

@henkka
Copy link
Copy Markdown
Contributor

@henkka henkka commented May 27, 2025

Closes #1138.

This pull request brings the missing "Get pull request file changes" functionality for the Bitbucket Datacenter forge.

@henkka henkka force-pushed the bb-pr-changes branch 2 times, most recently from ce786e2 to a4ba110 Compare May 27, 2025 11:35
@6543 6543 added enhancement improve existing features forge/bitbucket bitbucket forge related labels May 27, 2025
@6543
Copy link
Copy Markdown
Member

6543 commented May 27, 2025

looks good :) - Let us try to wait for upstream sdk to get it merged first

through i did run the CI so we can see if it would pass already 🚀

@henkka
Copy link
Copy Markdown
Contributor Author

henkka commented Jun 11, 2025

looks good :) - Let us try to wait for upstream sdk to get it merged first

through i did run the CI so we can see if it would pass already 🚀

@6543 in collaboration with @langecode we got the changes released in the upstream sdk, so I removed the replace directive and updated the sdk version in 90257ad

Copy link
Copy Markdown
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm in general

Comment thread server/forge/bitbucketdatacenter/bitbucketdatacenter.go
@henkka henkka requested a review from anbraten June 12, 2025 06:08
Copy link
Copy Markdown
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for the work

@anbraten anbraten changed the title feat(bitbucketdatacenter): support for pull request file changes Support for pull request file changes in bitbucketdatacenter Jun 12, 2025
@anbraten anbraten enabled auto-merge (squash) June 12, 2025 06:59
@woodpecker-bot
Copy link
Copy Markdown
Contributor

Deploying preview to https://woodpecker-ci-woodpecker-pr-5205.surge.sh

@anbraten anbraten merged commit aae9d61 into woodpecker-ci:main Jun 12, 2025
6 of 7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Jun 12, 2025
1 task
@henkka henkka deleted the bb-pr-changes branch June 12, 2025 07:48
@6543
Copy link
Copy Markdown
Member

6543 commented Jun 17, 2025

thx :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement improve existing features forge/bitbucket bitbucket forge related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forges missing Support of functions

4 participants