Skip to content

Allow username to be used with multiple forges#5676

Merged
6543 merged 7 commits into
woodpecker-ci:mainfrom
6543-forks:fix-multiforge-2
Oct 23, 2025
Merged

Allow username to be used with multiple forges#5676
6543 merged 7 commits into
woodpecker-ci:mainfrom
6543-forks:fix-multiforge-2

Conversation

@6543
Copy link
Copy Markdown
Member

@6543 6543 commented Oct 23, 2025

Followup of #5612 who missed that new we can have multiple users with same login name

@6543 6543 added bug Something isn't working server skip-changelog labels Oct 23, 2025
@6543
Copy link
Copy Markdown
Member Author

6543 commented Oct 23, 2025

skip because we already have #5612 in the changelog :)

@woodpecker-bot
Copy link
Copy Markdown
Contributor

woodpecker-bot commented Oct 23, 2025

Surge PR preview deployment was removed

@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.23%. Comparing base (c77ca3e) to head (d7f2b16).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/forge/gitea/gitea.go 0.00% 3 Missing ⚠️
server/api/login.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5676      +/-   ##
==========================================
- Coverage   21.23%   21.23%   -0.01%     
==========================================
  Files         423      423              
  Lines       38279    38280       +1     
==========================================
  Hits         8130     8130              
- Misses      29395    29396       +1     
  Partials      754      754              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread server/forge/gitea/gitea.go Outdated
@6543 6543 requested a review from a team October 23, 2025 12:28
Comment thread server/model/user.go
@anbraten anbraten changed the title Support multiple users with same login name but different forges (2) Allow username to be used with multiple forges Oct 23, 2025
Copy link
Copy Markdown
Member

@anbraten anbraten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm, haven't test it

Comment thread server/forge/gitea/gitea.go Outdated
Co-authored-by: Anbraten <6918444+anbraten@users.noreply.github.com>
@6543 6543 enabled auto-merge (squash) October 23, 2025 15:18
@6543 6543 merged commit 6fa1635 into woodpecker-ci:main Oct 23, 2025
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Oct 23, 2025
1 task
@6543 6543 deleted the fix-multiforge-2 branch October 23, 2025 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants