Support multiple users with same login name but different forges

[anbraten]

Currently we just lookup the user by it's login name.
If you have the same name on multible forges connected to Woodpecker, on login the repos randomly change the user of one forge to another witch then potentially sets the user of a different forge as the repo as repo owner ...
... other strange things can happen too ...

this changes it to have the forgeRemoteID be the primary way to lookup users inside the database...

[woodpecker-bot]

Shutting down https://woodpecker-ci-woodpecker-pr-5612.surge.sh

[6543]

beside that nit, like it ...

[6543]

PS: we have a simmilar problem if a organisation is renamed ...

[6543]

PS: PS: I'll address the test errors tomorow ... but the constrain should be here now ... as we use it as key for users now

[anbraten]

code lgtm

[codecov]

Codecov Report

❌ Patch coverage is 9.38967% with 193 lines in your changes missing coverage. Please review.
✅ Project coverage is 21.30%. Comparing base (fed0ced) to head (8a659dd).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
server/store/mocks/mock_Store.go	0.00%	92 Missing ⚠️
woodpecker-go/woodpecker/mocks/mock_Client.go	0.00%	48 Missing ⚠️
server/api/users.go	0.00%	41 Missing ⚠️
server/api/login.go	61.53%	4 Missing and 1 partial ⚠️
woodpecker-go/woodpecker/user.go	64.28%	5 Missing ⚠️
server/store/datastore/user.go	60.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #5612      +/-   ##
==========================================
- Coverage   21.31%   21.30%   -0.01%     
==========================================
  Files         420      420              
  Lines       38080    38163      +83     
==========================================
+ Hits         8116     8130      +14     
- Misses      29211    29280      +69     
  Partials      753      753              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[6543]

@anbraten I fixed more multi-user forge stuff you might review again :)

[6543]

@anbraten could you write lgtm or deny again :)

I know review dont work on own pulls 😓

[xoxys]

I dont like to introduce new cli flags using id's. Thats weird to use not human friendly and should be avoided.

[6543]

then I'll remove that cli change part for now

[6543]

@xoxys did remove the cli patch

[xoxys]

See my comments in the chat.

[xoxys]

Code LGMT, but hard to test locally. My personal preference would be an rc-release first, or release 3.11 without this change, and merge it after the release to get it battle-tested using the next tag.

[anbraten]

would keep the changes to the actual fix and a minimum as those areas apis are quite part of the core and therefore critical

[6543]

ugh ... I can strip it out 😓

[6543]

well thanks 😅 I still was going to split it out but that makes it way easyer for me :)

[xoxys]

As we have done the release without this PR, need to overcomplicate things IMO. Just keep in mind if we have to revert partially this needs to be done manually. If I misunderstood out discussion in the chat and overruled you @anbraten, sorry for that, this was not on purpose.

[6543]

no problem :) just ping me if there is an issue with this exact patch

[6543]

created snapshot and deployed on our own ci ...