local backend: fix steps having logs form other steps#5582
Merged
Conversation
…d-local-test-shell-posix
…d-local-test-shell-posix
…d-local-test-shell-posix
qwerty287
approved these changes
Oct 1, 2025
qwerty287
left a comment
Contributor
There was a problem hiding this comment.
Seems fine, but not tested from my side.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5582 +/- ##
==========================================
+ Coverage 19.79% 20.18% +0.39%
==========================================
Files 419 421 +2
Lines 39796 39874 +78
==========================================
+ Hits 7878 8049 +171
+ Misses 31210 31095 -115
- Partials 708 730 +22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
problem
if steps where started concurrent, the stdout pipeline reader war overwritten and you randomly got the wrong command stream
from a step.
change
where we have possible race conditions, we now use thread save types
e.g. store the command struct and the output reader in sync.Map
also a lot of tests where added
coverage
before: 14.9%
now: 59.2%