Skip to content

local backend: test shells if unknown#5570

Merged
6543 merged 22 commits into
woodpecker-ci:mainfrom
6543-forks:backend-local-test-shell-posix
Oct 1, 2025
Merged

local backend: test shells if unknown#5570
6543 merged 22 commits into
woodpecker-ci:mainfrom
6543-forks:backend-local-test-shell-posix

Conversation

@6543

@6543 6543 commented Sep 29, 2025

Copy link
Copy Markdown
Member

currently if we don't know the shell we just assume posix.
this adds a small test, to ensure it is and fail gracefully before doing weird stuff.

Test Conf

skip_clone: true
steps:
  build:
    image: "true"
    commands:
      - echo "building..."

Before

image

After

image

@6543 6543 added enhancement improve existing features wip backend/local labels Sep 29, 2025
@anbraten anbraten marked this pull request as draft September 29, 2025 18:22
@6543 6543 changed the title [Blocked] local backend test shells if unknown local backend test shells if unknown Sep 30, 2025
@6543 6543 removed the wip label Sep 30, 2025
@6543 6543 marked this pull request as ready for review September 30, 2025 15:08
@6543 6543 requested a review from a team September 30, 2025 15:11
@codecov

codecov Bot commented Sep 30, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 70.37037% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 19.82%. Comparing base (e11f110) to head (83503d8).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/backend/local/command.go 70.00% 6 Missing ⚠️
pipeline/backend/local/errors.go 71.42% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5570      +/-   ##
==========================================
+ Coverage   19.79%   19.82%   +0.02%     
==========================================
  Files         419      420       +1     
  Lines       39796    39820      +24     
==========================================
+ Hits         7878     7894      +16     
- Misses      31210    31218       +8     
  Partials      708      708              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@6543

6543 commented Sep 30, 2025

Copy link
Copy Markdown
Member Author

Base work for #5582

@xoxys xoxys left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Comment thread pipeline/backend/local/errors.go Outdated
6543 and others added 2 commits October 1, 2025 11:43
Co-authored-by: Robert Kaussow <xoxys@rknet.org>
@6543 6543 enabled auto-merge (squash) October 1, 2025 10:21
@6543 6543 merged commit 9edaa1e into woodpecker-ci:main Oct 1, 2025
7 checks passed
@woodpecker-bot woodpecker-bot mentioned this pull request Sep 30, 2025
1 task
@6543 6543 deleted the backend-local-test-shell-posix branch October 1, 2025 10:33
@6543 6543 changed the title local backend test shells if unknown local backend: test shells if unknown Oct 1, 2025
@woodpecker-bot woodpecker-bot mentioned this pull request Oct 2, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend/local enhancement improve existing features

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants