This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Don't register or unregister if block can't be found #11872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roykho
added
type: bug
|
The release ZIP for this PR is accessible via: TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the |
|
Size Change: +18 B (0%) Total Size: 1.61 MB
ℹ️ View Unchanged
|
wavvves
added
the
status: blocker
Aljullu
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Good catch with this issue, @roykho! Code changes look good to me and it's testing well. 
While testing this PR, I found another bug. I might be doing something wrong, but I created an issue just in case: #11882.
It's also happening on trunk, so not blocking this PR. And given that this is experimental, shouldn't block the release either.
danieldudzic
approved these changes
Nov 22, 2023
wavvves
approved these changes
Nov 22, 2023
wavvves
pushed a commit
that referenced
this pull request
Nov 22, 2023
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
|
I feel like there is still something wonky with this registration methods. I am occasionally seeing some race conditions where the |
I didn't notice any abnormal behavior. |
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
* Updated changelog and added testing instructions * Updated changelog. * Updated versions. * Updated tested up to * Updated tested up to * Uploaded testing zip * Removed #11287 from testing instructions * Added testing instructions and changelog for #11858 * Updated testing zip * Testing instructions for #11862 and #11860 * Updated testing zip * New testing zip with #11872 🍒 * Updated versions to 11.7.0-dev * Updated composer.lock
Same as @danieldudzic, I didn't find anything weird. But it's possibly we missed it if it's a race condition, I will keep an eye in case I can reproduce. |
6 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Fixes an issue with #11664
The PR caused a console error
blocks.min.js?ver=7204d43123223474471a:3 Block "woocommerce/product-gallery" is not registered.becauseproduct-galleryis under an experimental flag and production builds does not register experimental blocks.Why
To prevent errors in the console.
Testing Instructions
Please consider any edge cases this change may have, and also other areas of the product this may impact.
Test 1: Single Product template
Test 2: Posts
Test 3: Pages
Test 4:
npm run build:deployso that only production blocks are built.WooCommerce Visibility
Required: