This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
Validate coupon usage against customer id AND emails #11860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senadir
added
type: bug
woocommercebot
requested review from
a team and
wavvves
and removed request for
a team
senadir
force-pushed
the
fix/validate-coupoon-against-user-and-email
branch
from
49f98c8
to
376116a
Compare
|
The release ZIP for this PR is accessible via: Script Dependencies ReportThere is no changed script dependency between this branch and trunk. This comment was automatically generated by the TypeScript Errors Report
🎉 🎉 This PR does not introduce new TS errors. |
|
Size Change: 0 B Total Size: 1.61 MB ℹ️ View Unchanged
|
senadir
commented
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
reviewed
Nov 21, 2023
mikejolley
approved these changes
Nov 21, 2023
There was a problem hiding this comment.
✅ Test cases passed
✅ I fixed an issue with the checking of user email as well as billing email. New test case added, as well as updated the test cases for the notice on removal (which I changed to show why the coupon was removed)
✅ Code looks good.
This needs a second reviewer because I pushed some changes.
opr
approved these changes
Nov 21, 2023
wavvves
approved these changes
Nov 21, 2023
opr
pushed a commit
that referenced
this pull request
Nov 21, 2023
* validate coupon usage against user and email * add checks for logged out user * change to direct array call * fix the query * fix the query * fix arrays * fixe how id is fetched * Make function private * use implode instead of join * coupon shouldnt be a pointer * move ignore statement * add comment about tentative usage * Update src/StoreApi/Utilities/OrderController.php Co-authored-by: Mike Jolley <[email protected]> * better validation for user data * remove unused variable * bail early if we dont have limits * add empty line after function --------- Co-authored-by: Mike Jolley <[email protected]>
opr
pushed a commit
that referenced
this pull request
Nov 21, 2023
* validate coupon usage against user and email * add checks for logged out user * change to direct array call * fix the query * fix the query * fix arrays * fixe how id is fetched * Make function private * use implode instead of join * coupon shouldnt be a pointer * move ignore statement * add comment about tentative usage * Update src/StoreApi/Utilities/OrderController.php Co-authored-by: Mike Jolley <[email protected]> * better validation for user data * remove unused variable * bail early if we dont have limits * add empty line after function --------- Co-authored-by: Mike Jolley <[email protected]>
opr
pushed a commit
that referenced
this pull request
Nov 21, 2023
* validate coupon usage against user and email * add checks for logged out user * change to direct array call * fix the query * fix the query * fix arrays * fixe how id is fetched * Make function private * use implode instead of join * coupon shouldnt be a pointer * move ignore statement * add comment about tentative usage * Update src/StoreApi/Utilities/OrderController.php Co-authored-by: Mike Jolley <[email protected]> * better validation for user data * remove unused variable * bail early if we dont have limits * add empty line after function --------- Co-authored-by: Mike Jolley <[email protected]>
wavvves
pushed a commit
that referenced
this pull request
Nov 21, 2023
* validate coupon usage against user and email * add checks for logged out user * change to direct array call * fix the query * fix the query * fix arrays * fixe how id is fetched * Make function private * use implode instead of join * coupon shouldnt be a pointer * move ignore statement * add comment about tentative usage * Update src/StoreApi/Utilities/OrderController.php Co-authored-by: Mike Jolley <[email protected]> * better validation for user data * remove unused variable * bail early if we dont have limits * add empty line after function --------- Co-authored-by: Mike Jolley <[email protected]>
wavvves
added a commit
that referenced
this pull request
Nov 21, 2023
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
wavvves
added a commit
that referenced
this pull request
Nov 22, 2023
* Updated changelog and added testing instructions * Updated changelog. * Updated versions. * Updated tested up to * Updated tested up to * Uploaded testing zip * Removed #11287 from testing instructions * Added testing instructions and changelog for #11858 * Updated testing zip * Testing instructions for #11862 and #11860 * Updated testing zip * New testing zip with #11872 🍒 * Updated versions to 11.7.0-dev * Updated composer.lock
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WooCommerce would register coupon usage based on 2 elements, a user id if the customer has one, or the billing email.
There was an edge case in which a coupon can be used twice, once logged in with user id, and once logged out with billing email.
For the purpose of this fix, we consider emails to belong to a single user, so even as guest, it can't be used.
So in this PR, I check the coupon usage against a customer id, their billing email, and the account email (if those last 2 differ).
For a logged out customer, I first check if the email belongs to an existing user, and check its usage as well, as well as the billing email usage.
Fixes #11850
Testing Instructions
From logged in to logged out
User email vs billing email
From logged out to logged in
General regression testing
WooCommerce Visibility
Required:
Checklist
Required:
[type]label or a[skip-changelog]label.Changelog