Update Gradle to 7.4.2 & AGP to 7.2.1 #6824

oguzkocer · 2022-06-28T15:18:24Z

This PR updates Gradle version to 7.4.2 and Android Gradle Plugin version to 7.2.1.

Since Gradle update is just a patch, it only contains bug fixes. Here are the full release notes: https://docs.gradle.org/7.4.2/release-notes.html

The only major Android Gradle Plugin release since 7.1.1 is 7.2 which includes the following breaking change:

Starting with AGP 7.2, you can no longer share the same source directory across multiple source sets.
For example, you can’t use the same test sources for both unit tests and instrumentation tests. To learn more, see Change the default source sets configurations.

As far as I can tell if this is an issue for us it should result in a build time error, so as long as CI passes I don't think we need to worry about it.

peril-woocommerce · 2022-06-28T15:18:32Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

wpmobilebot · 2022-06-28T15:30:58Z

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

ParaskP7

LGTM! 💯

It just that there exists a Lint Failure that needs addressing:

The crash seems to involve the detector dagger.lint.DaggerKotlinIssueDetector.
You can try disabling it with something like this:
    android {
        lintOptions {
            disable "JvmStaticProvidesInObjectDetector", "FieldSiteTargetOnQualifierAnnotation", "ModuleCompanionObjects", "ModuleCompanionObjectsNotInModuleParent"
        }
    }

As far as I can tell if this is an issue for us it should result in a build time error, so as long as CI passes I don't think we need to worry about it.

Yes, I believe you are right! 👍

PS: I also triggered the UI Tests to verify that nothing is breaking there too.

Update Dagger to 2.42

…4.2-agp-to-7.2.1

….2.1' into update-dependencies-to-agp-7.2.1-versions

…7.2.1-versions Update our dependencies to AGP 7.2.1 PRs

wpmobilebot · 2022-07-07T19:10:19Z

Found 1 violations:

The PR caused the following dependency changes:

expand

-+--- androidx.databinding:viewbinding:7.1.1
++--- androidx.databinding:viewbinding:7.2.1
-+--- org.wordpress:utils:2.3.0
++--- org.wordpress:utils:2.6.0
 +--- com.automattic.tracks:experimentation:trunk-f25f5b5e77df8313f19d47d07e7411256d18df79
-|    +--- org.wordpress:fluxc:1.36.0 -> 1.45.1
-|    |    +--- org.wordpress:wellsql:1.7.0
-|    |    |    +--- com.android.support:support-annotations:28.0.0
-|    |    |    \--- org.wordpress.wellsql:wellsql-annotations:1.7.0
-|    |    +--- org.wordpress.fluxc:fluxc-annotations:1.45.1
-|    |    +--- org.greenrobot:eventbus:3.3.1 (*)
-|    |    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.9.3
-|    |    |    +--- com.squareup.okio:okio:2.8.0 -> 3.0.0
-|    |    |    |    \--- com.squareup.okio:okio-jvm:3.0.0
-|    |    |    |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.6.10 (*)
-|    |    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.31 -> 1.6.10
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.10 (*)
-|    |    +--- com.android.volley:volley:1.1.1 -> 1.2.0
-|    |    +--- androidx.paging:paging-runtime:2.1.2
-|    |    |    +--- androidx.paging:paging-common:2.1.2
-|    |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|    |    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.1.0 (*)
-|    |    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.1.0 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.4.1 (*)
-|    |    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.4.1 (*)
-|    |    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
-|    |    +--- com.goterl:lazysodium-android:5.0.2
-|    |    +--- net.java.dev.jna:jna:5.5.0
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
-|    |    +--- androidx.appcompat:appcompat:1.0.2 -> 1.4.1 (*)
-|    |    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
-|    |    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.3
-|    |    |    \--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|    |    +--- org.wordpress:utils:develop-eebc5d8e91a1d90190919f900f924b39c861a528 -> 2.3.0 (*)
-|    |    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
-|    |    |    +--- com.squareup.okhttp3:okhttp:4.9.2 -> 4.9.3 (*)
-|    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
-|    |    +--- com.google.code.gson:gson:2.8.5 -> 2.9.0
-|    |    +--- org.apache.commons:commons-text:1.1 -> 1.8 (*)
-|    |    +--- androidx.room:room-runtime:2.4.2
-|    |    |    +--- androidx.room:room-common:2.4.2
-|    |    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|    |    |    +--- androidx.sqlite:sqlite-framework:2.2.0
-|    |    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|    |    |    |    \--- androidx.sqlite:sqlite:2.2.0
-|    |    |    |         \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
-|    |    |    +--- androidx.sqlite:sqlite:2.2.0 (*)
-|    |    |    +--- androidx.arch.core:core-runtime:2.0.1 -> 2.1.0 (*)
-|    |    |    \--- androidx.annotation:annotation-experimental:1.1.0
-|    |    +--- androidx.room:room-ktx:2.4.2
-|    |    |    +--- androidx.room:room-common:2.4.2 (*)
-|    |    |    +--- androidx.room:room-runtime:2.4.2 (*)
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
-|    |    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
-|    |    +--- com.google.dagger:dagger:2.29.1 -> 2.41
-|    |    |    \--- javax.inject:javax.inject:1
-|    |    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.6.1 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.6.1 (*)
-|    \--- org.wordpress:utils:2.3.0 (*)
+|    \--- org.wordpress:utils:2.3.0 -> 2.6.0 (*)
 +--- com.automattic:Automattic-Tracks-Android:2.2.0
 |    \--- io.sentry:sentry-android-okhttp -> 5.4.3
-|         \--- com.squareup.okhttp3:okhttp -> 4.9.3 (*)
+|         \--- com.squareup.okhttp3:okhttp -> 4.9.3
+|              +--- com.squareup.okio:okio:2.8.0 -> 3.0.0
+|              |    \--- com.squareup.okio:okio-jvm:3.0.0
+|              |         +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.31 -> 1.6.10 (*)
+|              |         \--- org.jetbrains.kotlin:kotlin-stdlib-common:1.5.31 -> 1.6.10
+|              \--- org.jetbrains.kotlin:kotlin-stdlib:1.4.10 -> 1.6.10 (*)
-+--- org.wordpress:fluxc:1.45.1 (*)
++--- org.wordpress:fluxc:trunk-f44a381615f6d850e9c95071469424fbde6daff8
+|    +--- org.wordpress:wellsql:1.7.0
+|    |    \--- org.wordpress.wellsql:wellsql-annotations:1.7.0
+|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-f44a381615f6d850e9c95071469424fbde6daff8
+|    +--- org.greenrobot:eventbus:3.3.1 (*)
+|    +--- com.squareup.okhttp3:okhttp:4.9.0 -> 4.9.3 (*)
+|    +--- com.android.volley:volley:1.1.1 -> 1.2.0
+|    +--- androidx.paging:paging-runtime:2.1.2
+|    |    +--- androidx.paging:paging-common:2.1.2
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|    |    |    \--- androidx.arch.core:core-common:2.0.0 -> 2.1.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.0 -> 2.1.0 (*)
+|    |    +--- androidx.lifecycle:lifecycle-runtime:2.0.0 -> 2.4.1 (*)
+|    |    +--- androidx.lifecycle:lifecycle-livedata:2.0.0 -> 2.4.1 (*)
+|    |    \--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
+|    +--- com.goterl:lazysodium-android:5.0.2
+|    +--- net.java.dev.jna:jna:5.5.0
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-android-extensions-runtime:1.6.10
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.4.1 (*)
+|    +--- androidx.recyclerview:recyclerview:1.0.0 -> 1.2.1 (*)
+|    +--- androidx.exifinterface:exifinterface:1.0.0 -> 1.3.3
+|    |    \--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|    +--- com.squareup.okhttp3:okhttp-urlconnection:4.9.0 -> 4.9.2
+|    |    +--- com.squareup.okhttp3:okhttp:4.9.2 -> 4.9.3 (*)
+|    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.4.10 -> 1.6.10 (*)
+|    +--- com.google.code.gson:gson:2.8.5 -> 2.9.0
+|    +--- org.apache.commons:commons-text:1.1 -> 1.8 (*)
+|    +--- androidx.room:room-runtime:2.4.2
+|    |    +--- androidx.room:room-common:2.4.2
+|    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|    |    +--- androidx.sqlite:sqlite-framework:2.2.0
+|    |    |    +--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|    |    |    \--- androidx.sqlite:sqlite:2.2.0
+|    |    |         \--- androidx.annotation:annotation:1.0.0 -> 1.3.0
+|    |    +--- androidx.sqlite:sqlite:2.2.0 (*)
+|    |    +--- androidx.arch.core:core-runtime:2.0.1 -> 2.1.0 (*)
+|    |    \--- androidx.annotation:annotation-experimental:1.1.0
+|    +--- androidx.room:room-ktx:2.4.2
+|    |    +--- androidx.room:room-common:2.4.2 (*)
+|    |    +--- androidx.room:room-runtime:2.4.2 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
+|    +--- com.google.dagger:dagger:2.42
+|    |    \--- javax.inject:javax.inject:1
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.6.1 (*)
+|    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.6.1 (*)
-+--- org.wordpress.fluxc.plugins:woocommerce:1.45.1
-|    +--- org.wordpress:wellsql:1.7.0 (*)
-|    +--- org.wordpress.fluxc:fluxc-annotations:1.45.1
-|    +--- androidx.room:room-ktx:2.4.2 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-|    +--- org.wordpress:fluxc:1.45.1 (*)
-|    +--- org.apache.commons:commons-lang3:3.7 -> 3.9
-|    +--- com.google.code.gson:gson:2.8.5 -> 2.9.0
-|    +--- com.google.dagger:dagger:2.29.1 -> 2.41 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.6.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.6.1 (*)
-|    \--- androidx.room:room-runtime:2.4.2 (*)
++--- org.wordpress.fluxc.plugins:woocommerce:trunk-f44a381615f6d850e9c95071469424fbde6daff8
+|    +--- org.wordpress:wellsql:1.7.0 (*)
+|    +--- org.wordpress.fluxc:fluxc-annotations:trunk-f44a381615f6d850e9c95071469424fbde6daff8
+|    +--- androidx.room:room-ktx:2.4.2 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
+|    +--- org.wordpress:fluxc:trunk-f44a381615f6d850e9c95071469424fbde6daff8 (*)
+|    +--- org.apache.commons:commons-lang3:3.7 -> 3.9
+|    +--- com.google.code.gson:gson:2.8.5 -> 2.9.0
+|    +--- com.google.dagger:dagger:2.42 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-core:1.3.9 -> 1.6.1 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.3.9 -> 1.6.1 (*)
+|    \--- androidx.room:room-runtime:2.4.2 (*)
-+--- org.wordpress:login:0.13.0
-|    +--- com.google.android.gms:play-services-auth:18.1.0 -> 20.2.0 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.6.10 (*)
-|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.4.1 (*)
-|    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
-|    +--- androidx.media:media:1.2.1 (*)
-|    +--- androidx.legacy:legacy-support-v13:1.0.0
-|    |    \--- androidx.legacy:legacy-support-v4:1.0.0 (*)
-|    +--- androidx.gridlayout:gridlayout:1.0.0
-|    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
-|    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
-|    +--- androidx.constraintlayout:constraintlayout:2.0.4 -> 2.1.4 (*)
-|    +--- com.google.android.material:material:1.2.1 -> 1.6.1 (*)
-|    +--- androidx.core:core-ktx:1.3.2 -> 1.7.0 (*)
-|    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.13.2
-|    |    +--- com.github.bumptech.glide:gifdecoder:4.13.2
-|    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
-|    |    +--- com.github.bumptech.glide:disklrucache:4.13.2
-|    |    +--- com.github.bumptech.glide:annotations:4.13.2
-|    |    +--- androidx.fragment:fragment:1.3.1 -> 1.4.1 (*)
-|    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
-|    |    +--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
-|    |    \--- androidx.tracing:tracing:1.0.0 (*)
-|    +--- com.google.dagger:dagger:2.33 -> 2.41 (*)
-|    \--- com.google.dagger:dagger-android-support:2.33 -> 2.40.5
-|         +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|         +--- com.google.dagger:dagger-android:2.40.5
-|         |    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|         |    +--- com.google.dagger:dagger-lint-aar:2.40.5
-|         |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|         |    \--- javax.inject:javax.inject:1
-|         +--- com.google.dagger:dagger-lint-aar:2.40.5
-|         +--- androidx.activity:activity:1.3.1 -> 1.4.0 (*)
-|         +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|         +--- androidx.appcompat:appcompat:1.3.1 -> 1.4.1 (*)
-|         +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
-|         +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
-|         +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
-|         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.1 (*)
-|         \--- javax.inject:javax.inject:1
++--- org.wordpress:login:0.15.0
+|    +--- com.google.android.gms:play-services-auth:18.1.0 -> 20.2.0 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib:1.4.32 -> 1.6.10 (*)
+|    +--- androidx.appcompat:appcompat:1.0.2 -> 1.4.1 (*)
+|    +--- androidx.vectordrawable:vectordrawable-animated:1.1.0 (*)
+|    +--- androidx.media:media:1.2.1 (*)
+|    +--- androidx.legacy:legacy-support-v13:1.0.0
+|    |    \--- androidx.legacy:legacy-support-v4:1.0.0 (*)
+|    +--- androidx.gridlayout:gridlayout:1.0.0
+|    |    +--- androidx.core:core:1.0.0 -> 1.7.0 (*)
+|    |    \--- androidx.legacy:legacy-support-core-ui:1.0.0 (*)
+|    +--- androidx.constraintlayout:constraintlayout:2.0.4 -> 2.1.4 (*)
+|    +--- com.google.android.material:material:1.2.1 -> 1.6.1 (*)
+|    +--- androidx.core:core-ktx:1.3.2 -> 1.7.0 (*)
+|    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.13.2
+|    |    +--- com.github.bumptech.glide:gifdecoder:4.13.2
+|    |    |    \--- androidx.annotation:annotation:1.1.0 -> 1.3.0
+|    |    +--- com.github.bumptech.glide:disklrucache:4.13.2
+|    |    +--- com.github.bumptech.glide:annotations:4.13.2
+|    |    +--- androidx.fragment:fragment:1.3.1 -> 1.4.1 (*)
+|    |    +--- androidx.vectordrawable:vectordrawable-animated:1.0.0 -> 1.1.0 (*)
+|    |    +--- androidx.exifinterface:exifinterface:1.2.0 -> 1.3.3 (*)
+|    |    \--- androidx.tracing:tracing:1.0.0 (*)
+|    +--- com.google.dagger:dagger:2.42 (*)
+|    \--- com.google.dagger:dagger-android-support:2.42
+|         +--- com.google.dagger:dagger:2.42 (*)
+|         +--- com.google.dagger:dagger-android:2.42
+|         |    +--- com.google.dagger:dagger:2.42 (*)
+|         |    +--- com.google.dagger:dagger-lint-aar:2.42
+|         |    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|         |    \--- javax.inject:javax.inject:1
+|         +--- com.google.dagger:dagger-lint-aar:2.42
+|         +--- androidx.activity:activity:1.3.1 -> 1.4.0 (*)
+|         +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|         +--- androidx.appcompat:appcompat:1.3.1 -> 1.4.1 (*)
+|         +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
+|         +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
+|         +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
+|         +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.1 (*)
+|         \--- javax.inject:javax.inject:1
 +--- project :libs:cardreader
 |    \--- com.stripe:stripeterminal:2.10.0
 |         \--- com.stripe:stripeterminal-core:2.10.0
 |              +--- com.stripe:stripeterminal-internal-common:2.10.0
-|              |    \--- com.google.dagger:dagger:2.41 (*)
+|              |    \--- com.google.dagger:dagger:2.41 -> 2.42 (*)
-|              \--- com.google.dagger:dagger:2.41 (*)
+|              \--- com.google.dagger:dagger:2.41 -> 2.42 (*)
-+--- com.automattic:about:0.0.4
++--- com.automattic:about:0.0.6
-+--- com.google.dagger:hilt-android:2.40.5
-|    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|    +--- com.google.dagger:dagger-lint-aar:2.40.5
-|    +--- com.google.dagger:hilt-core:2.40.5
-|    |    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|    |    +--- com.google.code.findbugs:jsr305:3.0.2
-|    |    \--- javax.inject:javax.inject:1
-|    +--- com.google.code.findbugs:jsr305:3.0.2
-|    +--- androidx.activity:activity:1.3.1 -> 1.4.0 (*)
-|    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
-|    +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
-|    +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.1 (*)
-|    +--- androidx.savedstate:savedstate:1.1.0 (*)
-|    \--- javax.inject:javax.inject:1
++--- com.google.dagger:hilt-android:2.42
+|    +--- com.google.dagger:dagger:2.42 (*)
+|    +--- com.google.dagger:dagger-lint-aar:2.42
+|    +--- com.google.dagger:hilt-core:2.42
+|    |    +--- com.google.dagger:dagger:2.42 (*)
+|    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    \--- javax.inject:javax.inject:1
+|    +--- com.google.code.findbugs:jsr305:3.0.2
+|    +--- androidx.activity:activity:1.3.1 -> 1.4.0 (*)
+|    +--- androidx.annotation:annotation:1.2.0 -> 1.3.0
+|    +--- androidx.fragment:fragment:1.3.6 -> 1.4.1 (*)
+|    +--- androidx.lifecycle:lifecycle-common:2.3.1 -> 2.4.1 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel:2.3.1 -> 2.4.1 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-savedstate:2.3.1 -> 2.4.1 (*)
+|    +--- androidx.savedstate:savedstate:1.1.0 (*)
+|    +--- javax.inject:javax.inject:1
+|    \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
 +--- androidx.hilt:hilt-navigation-fragment:1.0.0
 |    \--- androidx.hilt:hilt-navigation:1.0.0
-|         \--- com.google.dagger:hilt-android:2.35 -> 2.40.5 (*)
+|         \--- com.google.dagger:hilt-android:2.35 -> 2.42 (*)
-+--- com.google.dagger:dagger-android-support:2.40.5 (*)
++--- com.google.dagger:dagger-android-support:2.42 (*)
 +--- com.zendesk:support:5.0.8
 |    +--- com.zendesk:support-providers:5.0.8
 |    |    +--- com.zendesk:core:4.0.6
-|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.41 (*)
+|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.42 (*)
 |    |    +--- com.zendesk:guide-providers:1.0.7
-|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.41 (*)
+|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.42 (*)
-|    |    \--- com.google.dagger:dagger:2.40 -> 2.41 (*)
+|    |    \--- com.google.dagger:dagger:2.40 -> 2.42 (*)
 |    +--- com.zendesk:guide:1.0.7
 |    |    +--- com.zendesk:messaging:5.2.3
-|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.41 (*)
+|    |    |    \--- com.google.dagger:dagger:2.40 -> 2.42 (*)
-|    |    \--- com.google.dagger:dagger-android:2.40 -> 2.40.5 (*)
+|    |    \--- com.google.dagger:dagger-android:2.40 -> 2.42 (*)
-|    \--- com.google.dagger:dagger-android:2.40 -> 2.40.5 (*)
+|    \--- com.google.dagger:dagger-android:2.40 -> 2.42 (*)
-+--- org.wordpress:mediapicker:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
-|    +--- org.wordpress.mediapicker:domain:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-|    |    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-|    |    +--- androidx.core:core-ktx:1.7.0 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
-|    +--- androidx.databinding:viewbinding:7.1.1 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-|    +--- com.google.android.material:material:1.5.0 -> 1.6.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
-|    +--- androidx.navigation:navigation-fragment-ktx:2.3.5 -> 2.4.1 (*)
-|    +--- androidx.core:core-ktx:1.7.0 (*)
-|    +--- androidx.appcompat:appcompat:1.4.1 (*)
-|    +--- androidx.constraintlayout:constraintlayout:2.1.1 -> 2.1.4 (*)
-|    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.0 (*)
-|    +--- androidx.datastore:datastore-preferences:1.0.0 (*)
-|    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.13.2 (*)
-|    +--- com.google.dagger:hilt-android:2.40.5 (*)
-|    +--- com.google.dagger:hilt-android-compiler:2.40.5
-|    |    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|    |    +--- com.google.dagger:dagger-compiler:2.40.5
-|    |    |    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|    |    |    +--- com.google.dagger:dagger-producers:2.40.5
-|    |    |    |    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|    |    |    |    +--- com.google.guava:failureaccess:1.0.1
-|    |    |    |    +--- com.google.guava:guava:31.0.1-jre (*)
-|    |    |    |    +--- javax.inject:javax.inject:1
-|    |    |    |    \--- org.checkerframework:checker-compat-qual:2.5.5
-|    |    |    +--- com.google.dagger:dagger-spi:2.40.5
-|    |    |    |    +--- com.google.dagger:dagger:2.40.5 -> 2.41 (*)
-|    |    |    |    +--- com.google.dagger:dagger-producers:2.40.5 (*)
-|    |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
-|    |    |    |    +--- com.google.devtools.ksp:symbol-processing-api:1.5.30-1.0.0
-|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
-|    |    |    |    +--- com.google.guava:failureaccess:1.0.1
-|    |    |    |    +--- com.google.guava:guava:31.0.1-jre (*)
-|    |    |    |    +--- com.squareup:javapoet:1.13.0
-|    |    |    |    +--- javax.inject:javax.inject:1
-|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
-|    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
-|    |    |    +--- com.google.googlejavaformat:google-java-format:1.5
-|    |    |    |    +--- com.google.guava:guava:22.0 -> 31.0.1-jre (*)
-|    |    |    |    \--- com.google.errorprone:javac-shaded:9-dev-r4023-3
-|    |    |    +--- com.google.guava:failureaccess:1.0.1
-|    |    |    +--- com.google.guava:guava:31.0.1-jre (*)
-|    |    |    +--- com.squareup:javapoet:1.13.0
-|    |    |    +--- javax.inject:javax.inject:1
-|    |    |    +--- net.ltgt.gradle.incap:incap:0.2
-|    |    |    +--- org.checkerframework:checker-compat-qual:2.5.5
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
-|    |    |    \--- org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.3.0
-|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.5.0 -> 1.6.10 (*)
-|    |    +--- com.google.dagger:dagger-spi:2.40.5 (*)
-|    |    +--- com.google.code.findbugs:jsr305:3.0.2
-|    |    +--- com.google.guava:failureaccess:1.0.1
-|    |    +--- com.google.guava:guava:31.0.1-jre (*)
-|    |    +--- com.squareup:javapoet:1.13.0
-|    |    +--- javax.annotation:jsr250-api:1.0
-|    |    +--- javax.inject:javax.inject:1
-|    |    +--- net.ltgt.gradle.incap:incap:0.2
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.5.30 -> 1.6.10 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.3.0 (*)
-|    \--- com.github.chrisbanes:PhotoView:2.3.0 (*)
++--- org.wordpress:mediapicker:0.1.0
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
+|    +--- org.wordpress.mediapicker:domain:0.1.0
+|    |    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
+|    |    +--- androidx.core:core-ktx:1.7.0 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
+|    +--- androidx.databinding:viewbinding:7.2.1 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
+|    +--- com.google.android.material:material:1.5.0 -> 1.6.1 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
+|    +--- androidx.navigation:navigation-fragment-ktx:2.3.5 -> 2.4.1 (*)
+|    +--- androidx.core:core-ktx:1.7.0 (*)
+|    +--- androidx.appcompat:appcompat:1.4.1 (*)
+|    +--- androidx.constraintlayout:constraintlayout:2.1.1 -> 2.1.4 (*)
+|    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.0 (*)
+|    +--- androidx.datastore:datastore-preferences:1.0.0 (*)
+|    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.13.2 (*)
+|    +--- com.google.dagger:hilt-android:2.42 (*)
+|    +--- com.google.dagger:hilt-android-compiler:2.42
+|    |    +--- com.google.dagger:dagger:2.42 (*)
+|    |    +--- com.google.dagger:dagger-compiler:2.42
+|    |    |    +--- com.google.dagger:dagger:2.42 (*)
+|    |    |    +--- com.google.dagger:dagger-producers:2.42
+|    |    |    |    +--- com.google.dagger:dagger:2.42 (*)
+|    |    |    |    +--- com.google.guava:failureaccess:1.0.1
+|    |    |    |    +--- com.google.guava:guava:31.0.1-jre (*)
+|    |    |    |    +--- javax.inject:javax.inject:1
+|    |    |    |    \--- org.checkerframework:checker-compat-qual:2.5.5
+|    |    |    +--- com.google.dagger:dagger-spi:2.42
+|    |    |    |    +--- com.google.dagger:dagger:2.42 (*)
+|    |    |    |    +--- com.google.dagger:dagger-producers:2.42 (*)
+|    |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    |    |    +--- com.google.devtools.ksp:symbol-processing-api:1.5.30-1.0.0
+|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.6.10 (*)
+|    |    |    |    +--- com.google.guava:failureaccess:1.0.1
+|    |    |    |    +--- com.google.guava:guava:31.0.1-jre (*)
+|    |    |    |    +--- com.squareup:javapoet:1.13.0
+|    |    |    |    +--- javax.inject:javax.inject:1
+|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
+|    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    |    +--- com.google.googlejavaformat:google-java-format:1.5
+|    |    |    |    +--- com.google.guava:guava:22.0 -> 31.0.1-jre (*)
+|    |    |    |    \--- com.google.errorprone:javac-shaded:9-dev-r4023-3
+|    |    |    +--- com.google.guava:failureaccess:1.0.1
+|    |    |    +--- com.google.guava:guava:31.0.1-jre (*)
+|    |    |    +--- com.squareup:javapoet:1.13.0
+|    |    |    +--- javax.inject:javax.inject:1
+|    |    |    +--- net.ltgt.gradle.incap:incap:0.2
+|    |    |    +--- org.checkerframework:checker-compat-qual:2.5.5
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.6.10 (*)
+|    |    |    \--- org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.4.2
+|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    |    +--- com.google.dagger:dagger-spi:2.42 (*)
+|    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    +--- com.google.guava:failureaccess:1.0.1
+|    |    +--- com.google.guava:guava:31.0.1-jre (*)
+|    |    +--- com.squareup:javapoet:1.13.0
+|    |    +--- javax.annotation:jsr250-api:1.0
+|    |    +--- javax.inject:javax.inject:1
+|    |    +--- net.ltgt.gradle.incap:incap:0.2
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.4.2 (*)
+|    \--- com.github.chrisbanes:PhotoView:2.3.0 (*)
-+--- org.wordpress.mediapicker:source-device:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-|    +--- org.wordpress.mediapicker:domain:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
-|    +--- com.google.dagger:hilt-android:2.40.5 (*)
-|    \--- com.google.dagger:hilt-android-compiler:2.40.5 (*)
++--- org.wordpress.mediapicker:source-device:0.1.0
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
+|    +--- org.wordpress.mediapicker:domain:0.1.0 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
+|    +--- com.google.dagger:hilt-android:2.42 (*)
+|    \--- com.google.dagger:hilt-android-compiler:2.42 (*)
-\--- org.wordpress.mediapicker:source-wordpress:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601
-     +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
-     +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
-     +--- org.wordpress.mediapicker:domain:trunk-d0db2634cf27511bec3ef9b837f9cfe27c5ab601 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
-     +--- com.google.dagger:hilt-android:2.40.5 (*)
-     \--- com.google.dagger:hilt-android-compiler:2.40.5 (*)
+\--- org.wordpress.mediapicker:source-wordpress:0.1.0
+     +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 (*)
+     +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 (*)
+     +--- org.wordpress.mediapicker:domain:0.1.0 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.1 (*)
+     +--- com.google.dagger:hilt-android:2.42 (*)
+     \--- com.google.dagger:hilt-android-compiler:2.42 (*)

Please review and act accordingly

oguzkocer · 2022-07-07T19:13:37Z

@ParaskP7 Similar to the WPAndroid PR, it looks like you missed this PR review. Since I merged the library updates, I am going to admin merge this to avoid breaking composite build for developers.

ParaskP7 · 2022-07-08T09:13:31Z

👋 @oguzkocer !

@ParaskP7 wordpress-mobile/WordPress-Android#16834 (comment), it looks like you missed this PR review. Since I merged the library updates, I am going to admin merge this to avoid breaking composite build for developers.

Ah, actually I was aware of this PR but I didn't review it because it was in a draft state (rightfully so) and I wasn't sure how you want me to handle the review on it. By the time you got to merge the dependant PRs it was already EOD, I should have waiting a bit to help you on that too. I hope I didn't block you somehow. 😊
Yes indeed, since I reviewed the other PRs that got merged into this, I think it was the right call to admin merge to this one as well, just like you did and in order to avoid breaking composite build for developers, thank you! 💯

oguzkocer added 2 commits June 28, 2022 11:18

Update Gradle to 7.4.2

d9399b9

Update AGP to 7.2.1

493b279

oguzkocer added the Tooling label Jun 28, 2022

oguzkocer added this to the 9.6 milestone Jun 28, 2022

ParaskP7 self-assigned this Jun 29, 2022

ParaskP7 reviewed Jun 29, 2022

View reviewed changes

oguzkocer and others added 3 commits July 1, 2022 09:17

Update Dagger to 2.42

c36c8ce

Merge pull request #6846 from woocommerce/update-dagger-to-2.42

968a1bd

Update Dagger to 2.42

Update our dependencies to AGP 7.2.1 PRs

e2fbabf

oguzkocer requested a review from ParaskP7 July 6, 2022 18:12

oguzkocer and others added 6 commits July 7, 2022 12:13

Update our dependencies to AGP 7.2.1 tagged version

3a184cc

Merge remote-tracking branch 'origin/trunk' into upgrade-gradle-to-7.…

7551671

…4.2-agp-to-7.2.1

Merge remote-tracking branch 'origin/upgrade-gradle-to-7.4.2-agp-to-7…

13102ac

….2.1' into update-dependencies-to-agp-7.2.1-versions

Exclude FluxC from tracks:experimentation dependency

339adad

Adds missing couponsEnabled argument to unit tests

281c79d

Merge pull request #6876 from woocommerce/update-dependencies-to-agp-…

c4b4b9e

…7.2.1-versions Update our dependencies to AGP 7.2.1 PRs

oguzkocer marked this pull request as ready for review July 7, 2022 19:10

oguzkocer merged commit 5404f67 into trunk Jul 7, 2022

oguzkocer deleted the upgrade-gradle-to-7.4.2-agp-to-7.2.1 branch July 7, 2022 19:26

ParaskP7 mentioned this pull request Mar 13, 2023

Hack week: Update target SDK from 31 to 33 #8538

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update Gradle to 7.4.2 & AGP to 7.2.1 #6824

Update Gradle to 7.4.2 & AGP to 7.2.1 #6824

oguzkocer commented Jun 28, 2022

peril-woocommerce bot commented Jun 28, 2022 •

edited

Loading

wpmobilebot commented Jun 28, 2022 •

edited

Loading

ParaskP7 left a comment

wpmobilebot commented Jul 7, 2022

oguzkocer commented Jul 7, 2022

ParaskP7 commented Jul 8, 2022

Update Gradle to 7.4.2 & AGP to 7.2.1 #6824

Update Gradle to 7.4.2 & AGP to 7.2.1 #6824

Conversation

oguzkocer commented Jun 28, 2022

peril-woocommerce bot commented Jun 28, 2022 • edited Loading

wpmobilebot commented Jun 28, 2022 • edited Loading

ParaskP7 left a comment

Choose a reason for hiding this comment

wpmobilebot commented Jul 7, 2022

The PR caused the following dependency changes:

oguzkocer commented Jul 7, 2022

ParaskP7 commented Jul 8, 2022

peril-woocommerce bot commented Jun 28, 2022 •

edited

Loading

wpmobilebot commented Jun 28, 2022 •

edited

Loading