Hack week: Update target SDK from 31 to 33 #8538

0nko · 2023-03-11T18:55:45Z

This PR updates the target SDK from 31 to 33 and makes the necessary changes:

Moved the package namespace declarations from the manifests to gradle files
~~Updated Gradle version to 7.3.0, which addressed the warning caused by the target SDK update~~
Implemented a notification permission request bar, which is displayed now if the app does not have the permission to send push notifications. The users can dismiss the bar and they won't be bothered by it afterwards. This changes the current behavior, which displayed the permission request on devices running Android 13 (API 33) immediately after the app launch. More info here.

Request bar	Permission dialog

More changes are required in the Media library, which are addressed in a separate PR.

To test:

You'll need a device running Android version 13 (API level 33) to test the new bahavior.

Start the app with a clean installation
Notice the notifications permission request is not displayed immediately after the launch anymore
Proceed with the login
Notice that a banner pops up at the bottom with a description of the permission request
Tap on Allow
Grant the notifications permission
Kill the app and start it again
Notice the banner doesn't pop up
Go to App info -> Permissions
Verify that Notifications is listed in the Allowed section
Go to the Storage settings and clear the app storage
Go back to the app and log in
Notice the permission banner pops up again
Tap on Dismiss
Kill the app and start it again
Notice the app doesn't pop up
Go to App info -> Permissions
Verify that Notifications is listed in the Not Allowed section

wpmobilebot · 2023-03-11T19:15:10Z

You can test the changes on this Pull Request by downloading an installable build, or scanning this QR code:

codecov-commenter · 2023-03-11T19:15:31Z

Codecov Report

Patch coverage has no change and project coverage change: -0.10 ⚠️

Comparison is base (bd59b78) 43.00% compared to head (dbceea7) 42.90%.

❗ Current head dbceea7 differs from pull request most recent head f45f432. Consider uploading reports for the commit f45f432 to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##              trunk    #8538      +/-   ##
============================================
- Coverage     43.00%   42.90%   -0.10%     
+ Complexity     3908     3871      -37     
============================================
  Files           818      803      -15     
  Lines         42881    42545     -336     
  Branches       5635     5609      -26     
============================================
- Hits          18441    18255     -186     
+ Misses        22818    22677     -141     
+ Partials       1622     1613       -9

Impacted Files	Coverage Δ
...rc/main/kotlin/com/woocommerce/android/AppPrefs.kt	`7.35% <0.00%> (-0.07%)`	⬇️
...rce/android/mediapicker/MediaPickerSetupFactory.kt	`0.00% <0.00%> (ø)`
...in/com/woocommerce/android/ui/main/MainContract.kt	`0.00% <ø> (ø)`
...n/com/woocommerce/android/ui/main/MainPresenter.kt	`43.68% <0.00%> (-2.71%)`	⬇️
...com/woocommerce/android/util/WooPermissionUtils.kt	`0.00% <0.00%> (ø)`

... and 40 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

settings.gradle

This reverts commit 2ee0173.

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/util/WooPermissionUtils.kt # WooCommerce/src/main/res/layout/activity_main.xml

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/AppPrefs.kt

peril-woocommerce · 2023-04-17T21:02:49Z

	Warnings
⚠️	PR is not assigned to a milestone.

Generated by 🚫 dangerJS

wpmobilebot · 2023-04-17T21:09:14Z

Found 1 violations:

The PR caused the following dependency changes:

expand

-+--- org.wordpress:mediapicker:0.1.1
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.7.20 (*)
-|    +--- org.wordpress.mediapicker:domain:0.1.1
-|    |    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.7.20 (*)
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-|    |    +--- androidx.core:core-ktx:1.7.0 -> 1.8.0 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
-|    +--- androidx.databinding:viewbinding:7.2.1 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-|    +--- com.google.android.material:material:1.5.0 -> 1.6.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
-|    +--- androidx.navigation:navigation-fragment-ktx:2.3.5 -> 2.5.3 (*)
-|    +--- androidx.core:core-ktx:1.7.0 -> 1.8.0 (*)
-|    +--- androidx.appcompat:appcompat:1.4.1 -> 1.5.0 (*)
-|    +--- androidx.constraintlayout:constraintlayout:2.1.1 -> 2.1.4 (*)
-|    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
-|    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.0 -> 2.5.1 (*)
-|    +--- androidx.datastore:datastore-preferences:1.0.0 (*)
-|    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.13.2 (*)
-|    +--- com.google.dagger:hilt-android:2.42 (*)
-|    +--- com.google.dagger:hilt-android-compiler:2.42
-|    |    +--- com.google.dagger:dagger:2.42 -> 2.44 (*)
-|    |    +--- com.google.dagger:dagger-compiler:2.42
-|    |    |    +--- com.google.dagger:dagger:2.42 -> 2.44 (*)
-|    |    |    +--- com.google.dagger:dagger-producers:2.42
-|    |    |    |    +--- com.google.dagger:dagger:2.42 -> 2.44 (*)
-|    |    |    |    +--- com.google.guava:failureaccess:1.0.1
-|    |    |    |    +--- com.google.guava:guava:31.0.1-jre -> 31.1-android (*)
-|    |    |    |    +--- javax.inject:javax.inject:1
-|    |    |    |    \--- org.checkerframework:checker-compat-qual:2.5.5
-|    |    |    +--- com.google.dagger:dagger-spi:2.42
-|    |    |    |    +--- com.google.dagger:dagger:2.42 -> 2.44 (*)
-|    |    |    |    +--- com.google.dagger:dagger-producers:2.42 (*)
-|    |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
-|    |    |    |    +--- com.google.devtools.ksp:symbol-processing-api:1.5.30-1.0.0
-|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.7.20 (*)
-|    |    |    |    +--- com.google.guava:failureaccess:1.0.1
-|    |    |    |    +--- com.google.guava:guava:31.0.1-jre -> 31.1-android (*)
-|    |    |    |    +--- com.squareup:javapoet:1.13.0
-|    |    |    |    +--- javax.inject:javax.inject:1
-|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
-|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
-|    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
-|    |    |    +--- com.google.googlejavaformat:google-java-format:1.5
-|    |    |    |    +--- com.google.guava:guava:22.0 -> 31.1-android (*)
-|    |    |    |    \--- com.google.errorprone:javac-shaded:9-dev-r4023-3
-|    |    |    +--- com.google.guava:failureaccess:1.0.1
-|    |    |    +--- com.google.guava:guava:31.0.1-jre -> 31.1-android (*)
-|    |    |    +--- com.squareup:javapoet:1.13.0
-|    |    |    +--- javax.inject:javax.inject:1
-|    |    |    +--- net.ltgt.gradle.incap:incap:0.2
-|    |    |    +--- org.checkerframework:checker-compat-qual:2.5.5
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
-|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
-|    |    |    \--- org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.4.2
-|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
-|    |    +--- com.google.dagger:dagger-spi:2.42 (*)
-|    |    +--- com.google.code.findbugs:jsr305:3.0.2
-|    |    +--- com.google.guava:failureaccess:1.0.1
-|    |    +--- com.google.guava:guava:31.0.1-jre -> 31.1-android (*)
-|    |    +--- com.squareup:javapoet:1.13.0
-|    |    +--- javax.annotation:jsr250-api:1.0
-|    |    +--- javax.inject:javax.inject:1
-|    |    +--- net.ltgt.gradle.incap:incap:0.2
-|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
-|    |    \--- org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.4.2 (*)
-|    \--- com.github.chrisbanes:PhotoView:2.3.0 (*)
++--- org.wordpress:mediapicker:0.1.2
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.7.20 (*)
+|    +--- org.wordpress.mediapicker:domain:0.1.2
+|    |    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.7.20 (*)
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+|    |    +--- androidx.core:core-ktx:1.7.0 -> 1.8.0 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
+|    +--- androidx.databinding:viewbinding:7.2.1 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+|    +--- com.google.android.material:material:1.5.0 -> 1.6.1 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
+|    +--- androidx.navigation:navigation-fragment-ktx:2.3.5 -> 2.5.3 (*)
+|    +--- androidx.core:core-ktx:1.7.0 -> 1.8.0 (*)
+|    +--- androidx.appcompat:appcompat:1.4.1 -> 1.5.0 (*)
+|    +--- androidx.constraintlayout:constraintlayout:2.1.1 -> 2.1.4 (*)
+|    +--- androidx.swiperefreshlayout:swiperefreshlayout:1.1.0 (*)
+|    +--- androidx.lifecycle:lifecycle-viewmodel-ktx:2.4.0 -> 2.5.1 (*)
+|    +--- androidx.datastore:datastore-preferences:1.0.0 (*)
+|    +--- com.github.bumptech.glide:glide:4.12.0 -> 4.13.2 (*)
+|    +--- com.google.dagger:hilt-android:2.42 (*)
+|    +--- com.google.dagger:hilt-android-compiler:2.42
+|    |    +--- com.google.dagger:dagger:2.42 -> 2.44 (*)
+|    |    +--- com.google.dagger:dagger-compiler:2.42
+|    |    |    +--- com.google.dagger:dagger:2.42 -> 2.44 (*)
+|    |    |    +--- com.google.dagger:dagger-producers:2.42
+|    |    |    |    +--- com.google.dagger:dagger:2.42 -> 2.44 (*)
+|    |    |    |    +--- com.google.guava:failureaccess:1.0.1
+|    |    |    |    +--- com.google.guava:guava:31.0.1-jre -> 31.1-android (*)
+|    |    |    |    +--- javax.inject:javax.inject:1
+|    |    |    |    \--- org.checkerframework:checker-compat-qual:2.5.5
+|    |    |    +--- com.google.dagger:dagger-spi:2.42
+|    |    |    |    +--- com.google.dagger:dagger:2.42 -> 2.44 (*)
+|    |    |    |    +--- com.google.dagger:dagger-producers:2.42 (*)
+|    |    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    |    |    +--- com.google.devtools.ksp:symbol-processing-api:1.5.30-1.0.0
+|    |    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.30 -> 1.7.20 (*)
+|    |    |    |    +--- com.google.guava:failureaccess:1.0.1
+|    |    |    |    +--- com.google.guava:guava:31.0.1-jre -> 31.1-android (*)
+|    |    |    |    +--- com.squareup:javapoet:1.13.0
+|    |    |    |    +--- javax.inject:javax.inject:1
+|    |    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
+|    |    |    |    \--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
+|    |    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    |    +--- com.google.googlejavaformat:google-java-format:1.5
+|    |    |    |    +--- com.google.guava:guava:22.0 -> 31.1-android (*)
+|    |    |    |    \--- com.google.errorprone:javac-shaded:9-dev-r4023-3
+|    |    |    +--- com.google.guava:failureaccess:1.0.1
+|    |    |    +--- com.google.guava:guava:31.0.1-jre -> 31.1-android (*)
+|    |    |    +--- com.squareup:javapoet:1.13.0
+|    |    |    +--- javax.inject:javax.inject:1
+|    |    |    +--- net.ltgt.gradle.incap:incap:0.2
+|    |    |    +--- org.checkerframework:checker-compat-qual:2.5.5
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
+|    |    |    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.5.32 -> 1.7.20 (*)
+|    |    |    \--- org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.4.2
+|    |    |         \--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
+|    |    +--- com.google.dagger:dagger-spi:2.42 (*)
+|    |    +--- com.google.code.findbugs:jsr305:3.0.2
+|    |    +--- com.google.guava:failureaccess:1.0.1
+|    |    +--- com.google.guava:guava:31.0.1-jre -> 31.1-android (*)
+|    |    +--- com.squareup:javapoet:1.13.0
+|    |    +--- javax.annotation:jsr250-api:1.0
+|    |    +--- javax.inject:javax.inject:1
+|    |    +--- net.ltgt.gradle.incap:incap:0.2
+|    |    +--- org.jetbrains.kotlin:kotlin-stdlib:1.6.10 -> 1.7.20 (*)
+|    |    \--- org.jetbrains.kotlinx:kotlinx-metadata-jvm:0.4.2 (*)
+|    \--- com.github.chrisbanes:PhotoView:2.3.0 (*)
-+--- org.wordpress.mediapicker:source-device:0.1.1
-|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.7.20 (*)
-|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-|    +--- org.wordpress.mediapicker:domain:0.1.1 (*)
-|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
-|    +--- com.google.dagger:hilt-android:2.42 (*)
-|    \--- com.google.dagger:hilt-android-compiler:2.42 (*)
++--- org.wordpress.mediapicker:source-device:0.1.2
+|    +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.7.20 (*)
+|    +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+|    +--- org.wordpress.mediapicker:domain:0.1.2 (*)
+|    +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
+|    +--- com.google.dagger:hilt-android:2.42 (*)
+|    \--- com.google.dagger:hilt-android-compiler:2.42 (*)
-\--- org.wordpress.mediapicker:source-wordpress:0.1.1
-     +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.7.20 (*)
-     +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
-     +--- org.wordpress.mediapicker:domain:0.1.1 (*)
-     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
-     +--- com.google.dagger:hilt-android:2.42 (*)
-     \--- com.google.dagger:hilt-android-compiler:2.42 (*)
+\--- org.wordpress.mediapicker:source-wordpress:0.1.2
+     +--- org.jetbrains.kotlin:kotlin-parcelize-runtime:1.6.10 -> 1.7.20 (*)
+     +--- org.jetbrains.kotlin:kotlin-stdlib-jdk8:1.6.10 -> 1.7.20 (*)
+     +--- org.wordpress.mediapicker:domain:0.1.2 (*)
+     +--- org.jetbrains.kotlinx:kotlinx-coroutines-android:1.5.2 -> 1.6.4 (*)
+     +--- com.google.dagger:hilt-android:2.42 (*)
+     \--- com.google.dagger:hilt-android-compiler:2.42 (*)

Please review and act accordingly

0nko · 2023-04-19T08:35:49Z

@kidinov @JorgeMucientes @ParaskP7 Because you like this PR so much, you'll be happy to know it's ready for a review 😝

JorgeMucientes · 2023-04-19T13:54:25Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainPresenter.kt

+    private val shouldShowNotificationsPermissionBar: Boolean
+        get() {
+            return VERSION.SDK_INT >= VERSION_CODES.TIRAMISU &&
+                mainView?.hasNotificationsPermission == false &&
+                !AppPrefs.getWasNotificationsPermissionBarDismissed() &&
+                selectedSite.get().connectionType == Jetpack
+        }
+


Minor np, I'd say we tend to add new UI logic to MainActivityViewModel for the sake of getting rid of the few presenters left bit by bit. Furthermore, adding it to the view model should be more straightforward as you won't have to add any interface functions and its implementations, just expose the NotificationsPermissionBar visibility as live data.

Oh, I wasn't even aware we had MainActivityViewModel since there was still a presenter 😅. I'll move it, thanks!

JorgeMucientes · 2023-04-19T13:55:34Z

...ommerce/src/main/kotlin/com/woocommerce/android/ui/message/NotificationsPermissionBarView.kt

+import com.woocommerce.android.util.WooAnimUtils
+import com.woocommerce.android.util.WooPermissionUtils
+
+class NotificationsPermissionBarView @JvmOverloads constructor(


Curious why didn't you go the Compose way here? Was it less straightforward?

It was just easier with the presenter, but now that I know about the VM, I converted it. I had to change the UI a bit because I was having trouble showing a transparent background behind the Card with ComposeView. Let me know what you think.

JorgeMucientes · 2023-04-19T14:28:39Z

WooCommerce/src/main/res/layout/fragment_my_store.xml

@@ -40,10 +41,10 @@

                    <androidx.compose.ui.platform.ComposeView
                        android:id="@+id/store_onboarding_view"
+                        style="@style/Woo.Card"


Interesting, why did you decide to add this style? Haven't noticed any impact on the UI after this change. Also, this style change will impact (in case it has an visible impact) the onboarding full screen mode which is not a card UI.
I'd say that if we need to fix any UI glitch on the onboarding UI, I'd handle it in the compose code. Let me know wdyt.

There was some UI inconsistency with the shadow or margins but I don't see it anymore.. I'll just get rid of it.

JorgeMucientes · 2023-04-19T14:30:32Z

libs/cardreader/src/main/AndroidManifest.xml


    <uses-permission android:name="android.permission.BLUETOOTH_SCAN" />
    <uses-permission android:name="android.permission.BLUETOOTH_CONNECT" />
    <uses-permission android:name="android.permission.ACCESS_FINE_LOCATION" />
+    <uses-permission android:name="android.permission.ACCESS_COARSE_LOCATION" />


Is this related to targeting API 33? Why are both needed now?

I'm not sure if it was caused by API 33 but I started seeing this warning, so I added this.

JorgeMucientes · 2023-04-19T14:31:08Z

WooCommerce/src/main/res/layout/notifications_permissions_bar.xml

+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:text="@string/dismiss"
+            android:layout_margin="0dp"


Np. Needed?

I added this so that the button text would have the same margin as the rest of the layout and IMO it looks better, but I can get rid of it.

Without the margin:

Yeah I agree looks better. Let's keep it as it is 👍🏼

JorgeMucientes · 2023-04-19T14:31:21Z

WooCommerce/src/main/res/layout/notifications_permissions_bar.xml

+            android:layout_width="wrap_content"
+            android:layout_height="wrap_content"
+            android:text="@string/allow"
+            android:layout_margin="0dp"


Np. Needed?

JorgeMucientes · 2023-04-19T14:37:03Z

WooCommerce/src/main/res/values/strings.xml

@@ -2251,6 +2253,8 @@
    <string name="permissions_denied_message">It looks like you turned off permissions required for this feature.&lt;br/&gt;&lt;br/&gt;To change this, edit your permissions and make sure &lt;strong&gt;%s&lt;/strong&gt; is enabled.</string>
    <string name="permission_camera">Camera</string>
    <string name="button_edit_permissions">Edit permissions</string>
+    <string name="notifications_permission_title">Notifications</string>
+    <string name="notifications_permission_description">We need your permission to send you push notifications for new orders, reviews, etc. delivered to your device.</string>


Is the string value correct? Feels a bit weird after the etc part. Should it be a comma after etc? Although I'm not an expert in English 😅

I just copied it from jetpack_benefits_modal_push_notifications_subtitle (Get push notifications for new orders, reviews, etc. delivered to your device.) and modified it, so I didn't really think about it. But it is ok :).

JorgeMucientes · 2023-04-19T14:39:01Z

Thanks for handling this task @0nko! 🏅. I did a first round and didn't find anything blocking. But I left a couple of questions and a few nitpicks I think are worth considering looking into before merging.

Also, I've seen there are some changes related to media picker library. Is there anything I should test related to that?

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainActivity.kt

0nko · 2023-04-20T11:47:31Z

Thanks for the review, @JorgeMucientes. I've addressed your comments, ready for another round.

0nko · 2023-04-20T14:04:51Z

Btw, the Media Picker has been already tested separately, so you don't need to spend too much time on it. Smoke testing is fine.

JorgeMucientes · 2023-04-20T15:48:33Z

Thanks for applying the suggestions @0nko. The code looks good and works as expected.

0nko added 9 commits March 10, 2023 20:57

Update resources

0cce6ac

Add new notifications permission bar view

bef40ca

Add the new permission and the associated helper functions

2eaf798

Add a preference to remember notification bar dismissal

c82b3ae

Clean up code

3424d07

Update margins and background colors

4738c2b

Update target SDK to 33

8dab2c5

Update Gradle version to 7.3.0 due to target SDK update

2ee0173

Move the package namespace declarations from manifest to gradle files

e954703

ParaskP7 reviewed Mar 13, 2023

View reviewed changes

settings.gradle Outdated Show resolved Hide resolved

0nko added 2 commits March 14, 2023 22:55

Revert "Update Gradle version to 7.3.0 due to target SDK update"

2636823

This reverts commit 2ee0173.

Move the notification permission bar display logic to the presenter

630139c

0nko added the type: technical debt Represents or solves tech debt of the project. label Mar 28, 2023

0nko added 3 commits March 29, 2023 10:28

Merge branch 'trunk' into hackweek/notifications-permission

8ef3f08

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/util/WooPermissionUtils.kt # WooCommerce/src/main/res/layout/activity_main.xml

Merge branch 'trunk' into hackweek/notifications-permission

a7e3020

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/AppPrefs.kt

Update the MediaPicker library to 0.1.2 and make the necessary changes

c2b8221

0nko marked this pull request as ready for review April 17, 2023 21:03

0nko requested review from kidinov, JorgeMucientes, hafizrahman and wzieba April 17, 2023 21:03

0nko added 2 commits April 18, 2023 12:10

Add the missing string

dbceea7

Merge branch 'trunk' into hackweek/notifications-permission

669c94b

JorgeMucientes self-assigned this Apr 19, 2023

JorgeMucientes approved these changes Apr 19, 2023

View reviewed changes

JorgeMucientes reviewed Apr 19, 2023

View reviewed changes

0nko added 7 commits April 20, 2023 11:03

Merge branch 'trunk' into hackweek/notifications-permission

f45f432

# Conflicts: # WooCommerce/src/main/kotlin/com/woocommerce/android/ui/main/MainActivity.kt

Move notification permission bar logic to the ViewModel

99fb2fd

Remove the card style from the onboarding card

48b1b9c

Convert the notifications permission bar view to Compose UI

0a8efd8

Remove the old view

7d668bd

Add the icon back

0dec1cc

Fix ktlint issues

a4dc842

Fix the color reference

97af4d7

JorgeMucientes enabled auto-merge April 20, 2023 15:50

JorgeMucientes merged commit e3d044e into trunk Apr 20, 2023

JorgeMucientes deleted the hackweek/notifications-permission branch April 20, 2023 15:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hack week: Update target SDK from 31 to 33 #8538

Hack week: Update target SDK from 31 to 33 #8538

0nko commented Mar 11, 2023 •

edited

Loading

wpmobilebot commented Mar 11, 2023 •

edited

Loading

codecov-commenter commented Mar 11, 2023 •

edited

Loading

peril-woocommerce bot commented Apr 17, 2023 •

edited

Loading

wpmobilebot commented Apr 17, 2023

0nko commented Apr 19, 2023

JorgeMucientes Apr 19, 2023

0nko Apr 20, 2023

JorgeMucientes Apr 19, 2023

0nko Apr 20, 2023

JorgeMucientes Apr 19, 2023

0nko Apr 20, 2023

JorgeMucientes Apr 19, 2023

0nko Apr 20, 2023

JorgeMucientes Apr 19, 2023

0nko Apr 20, 2023

JorgeMucientes Apr 20, 2023 •

edited

Loading

JorgeMucientes Apr 19, 2023

JorgeMucientes Apr 19, 2023

0nko Apr 20, 2023

JorgeMucientes commented Apr 19, 2023

0nko commented Apr 20, 2023

0nko commented Apr 20, 2023

JorgeMucientes commented Apr 20, 2023

Hack week: Update target SDK from 31 to 33 #8538

Hack week: Update target SDK from 31 to 33 #8538

Conversation

0nko commented Mar 11, 2023 • edited Loading

wpmobilebot commented Mar 11, 2023 • edited Loading

codecov-commenter commented Mar 11, 2023 • edited Loading

Codecov Report

peril-woocommerce bot commented Apr 17, 2023 • edited Loading

wpmobilebot commented Apr 17, 2023

The PR caused the following dependency changes:

0nko commented Apr 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JorgeMucientes Apr 20, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JorgeMucientes commented Apr 19, 2023

0nko commented Apr 20, 2023

0nko commented Apr 20, 2023

JorgeMucientes commented Apr 20, 2023

0nko commented Mar 11, 2023 •

edited

Loading

wpmobilebot commented Mar 11, 2023 •

edited

Loading

codecov-commenter commented Mar 11, 2023 •

edited

Loading

peril-woocommerce bot commented Apr 17, 2023 •

edited

Loading

JorgeMucientes Apr 20, 2023 •

edited

Loading