Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Onboarding: Connect to existing Ads account in Google Accounts Card #2640

Open
wants to merge 9 commits into
base: feature/2567-kickoff-mc-ads-account-creation
Choose a base branch
from
Open

Onboarding: Connect to existing Ads account in Google Accounts Card #2640

wants to merge 9 commits into from

Commits on Oct 4, 2024

  1. Onboarding: Connect to existing Ads account in Google Accounts Card

    @ankitrox
    ankitrox committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    63b182b View commit details
    Browse the repository at this point in the history

  2. Conflict resolution

    @ankitrox
    ankitrox committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    f73c4b2 View commit details
    Browse the repository at this point in the history

  3. Add rendering condition.

    @ankitrox
    ankitrox committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    96e3ef2 View commit details
    Browse the repository at this point in the history

  4. Separate components for body and footer.

    @ankitrox
    ankitrox committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    7e73f98 View commit details
    Browse the repository at this point in the history

  5. Connected label styling

    @ankitrox
    ankitrox committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    ba5ca7b View commit details
    Browse the repository at this point in the history

  6. Pass isVisible prop to card component.

    @ankitrox
    ankitrox committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    df93a29 View commit details
    Browse the repository at this point in the history

  7. Use ref for keeping connected account selected.

    @ankitrox
    ankitrox committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    6fce3e6 View commit details
    Browse the repository at this point in the history

  8. Add E2E tests.

    @ankitrox
    ankitrox committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    4173593 View commit details
    Browse the repository at this point in the history

  9. Fix lint css.

    @ankitrox
    ankitrox committed Oct 4, 2024
    Configuration menu
    Copy the full SHA
    2466f7e View commit details
    Browse the repository at this point in the history