Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Onboarding: Connect to existing Ads account in Google Accounts Card #2640

Open
wants to merge 9 commits into
base: feature/2567-kickoff-mc-ads-account-creation
Choose a base branch
from

Conversation

ankitrox
Copy link
Collaborator

@ankitrox ankitrox commented Oct 4, 2024

Changes proposed in this Pull Request:

Closes #2596 .

Replace this with a good description of your changes & reasoning.

Screenshots:

Screenshot 2024-10-04 at 10 37 36 PM

Detailed test instructions:

Additional details:

Changelog entry

@github-actions github-actions bot added the changelog: update Big changes to something that wasn't broken. label Oct 4, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.0%. Comparing base (896c681) to head (4173593).

Additional details and impacted files

Impacted file tree graph

@@                             Coverage Diff                              @@
##           feature/2567-kickoff-mc-ads-account-creation   #2640   +/-   ##
============================================================================
  Coverage                                          63.0%   63.0%           
============================================================================
  Files                                               323     323           
  Lines                                              5160    5156    -4     
  Branches                                           1269    1265    -4     
============================================================================
- Hits                                               3250    3248    -2     
+ Misses                                             1734    1733    -1     
+ Partials                                            176     175    -1     
Flag Coverage Δ
js-unit-tests 63.0% <ø> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: update Big changes to something that wasn't broken.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant