-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboarding: Connect to existing Ads account in Google Accounts Card #2640
Open
ankitrox
wants to merge
9
commits into
feature/2567-kickoff-mc-ads-account-creation
Choose a base branch
from
update/2596-connect-ads-account
base: feature/2567-kickoff-mc-ads-account-creation
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Onboarding: Connect to existing Ads account in Google Accounts Card #2640
ankitrox
wants to merge
9
commits into
feature/2567-kickoff-mc-ads-account-creation
from
update/2596-connect-ads-account
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog: update
Big changes to something that wasn't broken.
label
Oct 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/2567-kickoff-mc-ads-account-creation #2640 +/- ##
============================================================================
Coverage 63.0% 63.0%
============================================================================
Files 323 323
Lines 5160 5156 -4
Branches 1269 1265 -4
============================================================================
- Hits 3250 3248 -2
+ Misses 1734 1733 -1
+ Partials 176 175 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
Closes #2596 .
Replace this with a good description of your changes & reasoning.
Screenshots:
Detailed test instructions:
Additional details:
Changelog entry