Log Exception if an asset is enqueued before being registered

[martynmjones]

Changes proposed in this Pull Request:

Closes #1659

Adjusts asset enqueuing to catch InvalidAsset exceptions thrown when an asset is enqueued before being registered.

Detailed test instructions:

1. Without checking out this branch, install and activate WooCommerce Print Invoices and Packing Lists on a site that has GLA setup complete
2. Install and activate WP Consent API
3. Make sure Google Analytics for WooCommerce is not active on the site
4. Go to WooCommerce > Settings > Invoices/Packing Lists
5. Click on Customize under Template Customizer
6. See the fatal error triggered by the uncaught InvalidAsset exception
7. Checkout fix/1659-asset-enqueued-before-registered
8. Repeat step 3
9. Confirm no error is displayed
10. Go to WooCommerce > Status > Logs
11. Confirm the error was logged in the google-listings-and-ads-... log file

Changelog entry

Fix - Log exceptions triggered by assets being enqueued before being registered

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.2%. Comparing base (93b4180) to head (0baf754).
Report is 27 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##             develop   #2576     +/-   ##
===========================================
+ Coverage       64.5%   65.2%   +0.6%     
- Complexity      4591    4592      +1     
===========================================
  Files            796     475    -321     
  Lines          22992   17909   -5083     
  Branches        1234       0   -1234     
===========================================
- Hits           14837   11671   -3166     
+ Misses          7982    6238   -1744     
+ Partials         173       0    -173     

Flag	Coverage Δ
js-unit-tests	?
php-unit-tests	65.2% <100.0%> (+0.1%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
src/Assets/BaseAsset.php	75.7% <100.0%> (+18.4%)	⬆️

... and 324 files with indirect coverage changes

[jorgemd24]

Hi @martynmjones, thanks for working on this! However, I wasn't able to reproduce the issue. I followed the steps but didn't get the fatal error. On my local machine I see the following when I go to Customize:

1. The plugin_loaded hook is called, which registers the GlobalSiteTag Assets:

google-listings-and-ads/src/Google/GlobalSiteTag.php

Line 143 in 12c09f8

$this->register_assets();

2. The template_redirect hook is called, and wp_footer is triggered in the PIP plugin at: wp-content/plugins/woocommerce-pip/src/admin/class-wc-pip-customizer.php:880.

The PIP version that I am using is: 3.13.6

What am I doing differently?

[martynmjones]

What am I doing differently?

Apologies @jorgemd24, for the error to be triggered in the example I gave, we need GLA to enqueue gla-wp-consent-api so these conditions need to be satisfied on the test site.

I've updated the test instructions to include installing and activating WP Consent API and making sure Google Analytics for WooCommerce is not active. You should then see the fatal error in the customizer.

Apologies again for the trouble!

[jorgemd24]

Thanks for the explanation! I was able to reproduce the issue, and I see that this PR catch the fatal error, so it looks good to me!