Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update budget recommendation text #2629

Open
wants to merge 1 commit into
base: feature/2459-campaign-creation-flow
Choose a base branch
from

Conversation

kt-12
Copy link
Collaborator

@kt-12 kt-12 commented Sep 30, 2024

Changes proposed in this Pull Request:

Closes #2600 .

Text updated to reflect the change. Check screenshot.

Screenshots:

Multiple Counties selected
Screenshot 2024-09-30 at 10 42 21

Single country selected
Screenshot 2024-09-30 at 10 42 13

Detailed test instructions:

  1. On "Create your paid campaign" page select single country
  2. Check if the text change is reflected.
  3. Now select an additional country and see if the text is same as shown in the screenshot above.

Additional details:

Changelog entry

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.6%. Comparing base (24044c5) to head (b581d13).
Report is 131 commits behind head on feature/2459-campaign-creation-flow.

Additional details and impacted files

Impacted file tree graph

@@                           Coverage Diff                            @@
##             feature/2459-campaign-creation-flow   #2629      +/-   ##
========================================================================
- Coverage                                   64.7%   62.6%    -2.1%     
========================================================================
  Files                                        793     319     -474     
  Lines                                      22967    5063   -17904     
  Branches                                    1231    1232       +1     
========================================================================
- Hits                                       14865    3171   -11694     
+ Misses                                      7929    1718    -6211     
- Partials                                     173     174       +1     
Flag Coverage Δ
js-unit-tests 62.6% <ø> (-<0.1%) ⬇️
php-unit-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...-ads/budget-section/budget-recommendation/index.js 4.0% <ø> (ø)

... and 494 files with indirect coverage changes

@asvinb
Copy link
Collaborator

asvinb commented Sep 30, 2024

LGTM @kt-12

@joemcgill joemcgill changed the base branch from develop to feature/2459-campaign-creation-flow September 30, 2024 19:59
@ankitguptaindia
Copy link
Member

Changes Look good and working as expected. ✅

Recording.883.mp4

@eason9487 eason9487 added the changelog: none Skip changelog entry for this PR label Oct 7, 2024
Copy link
Member

@eason9487 eason9487 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kt-12, the change looks good.

Could you make this PR not include file changes that don't belong to it?

1

@kt-12 kt-12 force-pushed the enhancement/2600-update-budget-text branch from b1f9944 to b581d13 Compare October 7, 2024 14:01
@kt-12
Copy link
Collaborator Author

kt-12 commented Oct 7, 2024

@eason9487 I am unsure how those commits ended up here. This was not the case till after 10upCR. I have removed those commits. It's good for WooCr review now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: none Skip changelog entry for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review budget recommendation text
4 participants