Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review budget recommendation text #2600

Open
1 task
asvinb opened this issue Sep 11, 2024 · 6 comments · May be fixed by #2629
Open
1 task

Review budget recommendation text #2600

asvinb opened this issue Sep 11, 2024 · 6 comments · May be fixed by #2629
Assignees
Labels
type: enhancement The issue is a request for an enhancement.

Comments

@asvinb
Copy link
Collaborator

asvinb commented Sep 11, 2024

Following the removal of the Ads Audience section in #2501, the budget recommendation text has become unclear, as users can no longer select or view the countries targeted for their ads.

image

Acceptance Criteria

  • The text should be updated to "Google will optimize your ads to maximize performance. Tip: Most merchants who sell products on similar countries set a daily budget of $X"

Implementation Brief

  • Update BudgetRecommendation to set the recommended budget text as per the AC.

Test Coverage

  • Tests should be updated if necessary.

Definition Questions

@asvinb asvinb added the type: enhancement The issue is a request for an enhancement. label Sep 11, 2024
@fblascogarma
Copy link
Collaborator

fblascogarma commented Sep 11, 2024

Good callout! Let's replace that wording for: "Google will optimize your ads to maximize performance. Tip: Most merchants who sell products on similar countries set a daily budget of $X"

What do you think?

@asvinb
Copy link
Collaborator Author

asvinb commented Sep 16, 2024

Sounds good @fblascogarma .

@asvinb
Copy link
Collaborator Author

asvinb commented Sep 16, 2024

@joemcgill @eclarke1 IB has been updated and AC updated as per @fblascogarma comment.

@eclarke1
Copy link
Collaborator

Thanks, moved to To Do for sprint 4

@joemcgill joemcgill removed their assignment Sep 16, 2024
@ankitrox
Copy link
Collaborator

@fblascogarma @asvinb @joemcgill I think we should use in instead of on in the sentence.

"In similar countries" might be the correct preposition to indicate where merchants are selling their products.

@kt-12 kt-12 self-assigned this Sep 30, 2024
@kt-12
Copy link
Collaborator

kt-12 commented Sep 30, 2024

@asvinb @joemcgill I have updated the the first line for case where there is just a single country to be match to that of multiple countries

"Google will optimize your ads to maximize performance. Tip:"

Old text
Screenshot 2024-09-30 at 10 32 21

@kt-12 kt-12 linked a pull request Sep 30, 2024 that will close this issue
@kt-12 kt-12 assigned asvinb and unassigned kt-12 Sep 30, 2024
@asvinb asvinb assigned ankitguptaindia and unassigned asvinb Sep 30, 2024
@eason9487 eason9487 assigned kt-12 and unassigned eason9487 Oct 7, 2024
@kt-12 kt-12 assigned eason9487 and unassigned kt-12 Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement The issue is a request for an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants