Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamlined Free Listings + Paid Ads and Ads Billing Pop-up for the onboarding flow #1722

Merged
merged 166 commits into from
Oct 18, 2022
Merged

Streamlined Free Listings + Paid Ads and Ads Billing Pop-up for the onboarding flow #1722

merged 166 commits into from
Oct 18, 2022

Conversation

eason9487
Copy link
Member

@eason9487 eason9487 commented Oct 7, 2022 •
edited
Loading

Changes proposed in this Pull Request:

Closes #1610

This PR merges the shared feature branch that includes Streamlined Free Listings + Paid Ads and Ads Billing Pop-up features to the main branch develop.

💡 All code changes have been reviewed and tested in the respective PRs. Therefore, this PR should not require extra rounds of code review.

Changelog entry

Add - Streamlined Free Listings + Paid Ads for the onboarding flow.
Update - Open the billing setup page of Google Ads via a popup window and add an alternative hyperlink to open the same setup page.

@eason9487
Move SetupFreeListings component of editing free listings to the shar…
4881f34 
…ed directory
@eason9487
Change the shared ChooseAudience to ChooseAudienceSection and merge i…
93249e6 
…t into SetupFreeListings for the editing free listings page
@eason9487
Add validations for merged audience values in the shared SetupFreeLis…
79911f8 
…tings
@eason9487
Replace SetupFreeListings with the shared one for the onboarding flow
55e2c09
@eason9487
Catch errors when saving data in the SavedSetupStepper of onboarding …
193ab56 
…flow
@eason9487
Remove unused files
20e758f
@eason9487
Remove an unused npm package use-debounce
fdf10dc
@eason9487
Add the CountryCode type back to SetupFreeListings
159bd2d
@eason9487
Add auto-saving for MC settings to fall back with the original implem…
43a2f76 
…entation
@eason9487
Adjust layouts and copywriting for the Get Started page
a473be5
@eason9487
Adjust layouts for StepContentHeader
0980e14
@eason9487
Change the logos of Google MC and Ads account cards
d5510e5
@eason9487
Adjust layouts and copywriting for the accounts setup step
fbf5235
@eason9487
Adjust layouts and copywriting for the product listings config step
8ea440d
@eason9487
Adjust layouts and copywriting for the store requirements confirmatio…
6f5cd0b 
…n step
@eason9487
Add image mock to jest config to fix JS unit tests
aede3e7
@eason9487
Fix a failed e2e test case due to copywriting change
1f2b568
@eason9487
Adjust the logic of step value reutrned by mc/setup API to fit wi…
cf5a18e 
…th the new 4-step
@eason9487
Add a new getProductFeedUrl function to utils/urls.js
ab1c7eb
@eason9487
Add a new component SetupPaidAds as the Paid Ads setup step in the on…
893b943 
…boarding flow
@eason9487
Adjust the mapping of step keys and add step 4 to the onboarding flow
026abb4
@eason9487
Add JSDoc for the handleFormChange function in SavedSetupStepper co…
d8ecc08 
…mponent.

Address #1616 (comment)
@eason9487
Merge pull request #1616 from woocommerce/update/1610-merge-audience-…
16244ee 
…shipping-step-2-3

Free Listings + Paid Ads: Combine the audience and shipping steps
@eason9487
Update copywriting that missed the revision for the onboarding flow.
25a7d8a 
Address
- #1618 (comment)
- #1618 (comment)
- #1618 (comment)
@eason9487
Merge two test cases that both test the same step product_listings …
093b68e 
…of MC setup status into one.

Address #1619 (comment)
@eason9487
Merge pull request #1618 from woocommerce/update/1610-ui-updates-get-…
34de75a 
…started-onboarding

Free Listings + Paid Ads: UI updates for get started page and onboarding flow
@eason9487
Merge pull request #1619 from woocommerce/update/1610-add-onboarding-…
680e817 
…step4

Free Listings + Paid Ads: Add step 4 to the onboarding flow
@eason9487
Merge branch 'develop' into feature/1610-streamlined-onboarding
6bcd41c
@eason9487
Extract a code fragment from the sync-status.js as `getNumberOfSyncPr…
9333fa5 
…oducts` function
@eason9487
Implement ProductFeedStatusSection component and add it to the paid a…
603438a 
…ds setup step of onboarding flow
eason9487 and others added 14 commits October 5, 2022 12:22
@eason9487
Merge branch 'develop' into feature/1610-streamlined-onboarding
ff43ed7
@eason9487
Add a new field phone_verification_status to the API `GET mc/contac…
f14afcf 
…t-information`
@eason9487
Add a phone verification status check to MerchantCenterService->is_mc…
fdfa239 
…_contact_information_setup
@eason9487
Add a new property isVerified to the returning data of `useGoogleMC…
cdbf344 
…PhoneNumber` hook
@eason9487
Detect the verification status of the phone number in the onboarding …
c4e45c7 
…flow
@eason9487
Add the verification status of the phone number to PhoneNumberCardPre…
4cf3f29 
…view component
@ianlin
Call array_unique for a smaller dataset when updating syncable products
c96b4c3 
count
@ianlin
Revert "Refactor find_mc_not_synced_product_ids so it'll process faster"
459cd23 
This reverts commit eb9f841.
@ianlin
Revert "Group variations with same parent for not synced products of …
cffa97f 
…statistics API"

This reverts commit 409742b.
@ianlin
Revert "Group variations with same parent for synced products of stat…
caa7228 
…istics API"

This reverts commit 4c01002.
@eason9487
Change the Stepper in the onboarding flow to only allow going back to…
789cb42 
… the previous steps
@eason9487
Add component handler to CampaignPreview and a new prop autoplay.
b9433e1
@eason9487
Create a new component CampaignPreviewCard for the paid ads setup flo…
3fa1872 
…w of post-onboarding.
@eason9487
Add CampaignPreviewCard to the paid ads setup flow of post-onboarding.
759e78e
@eason9487 eason9487 added the changelog: add A new feature, function, or functionality was added. label Oct 7, 2022
@ianlin
Ignore invalid product or nonpublish product in maybe_swap_for_parent…
ad96bf5 
…_ids
@ianlin
Add a test of product gets deleted after batch gets created
856eeee
@ianlin
Fix typo
3d64f9d
@ianlin
Merge pull request #1713 from woocommerce/update/1610-group-variation…
8bf3aa3 
…s-type-for-syncable-products

Free Listings + Paid Ads: Group variations type for syncable products
@ianlin
Merge pull request #1720 from woocommerce/fix/1684-onboarding-switch-…
d484955 
…step

Change the Stepper in the onboarding flow to only allow going back to the previous steps
@ianlin
Merge pull request #1717 from woocommerce/update/1033-phone-number-ve…
b47ad11 
…rification-status

Detect the verification status of the phone number to the contact information settings
@ianlin
Merge pull request #1721 from woocommerce/add/1610-post-onboarding-ad…
24498c8 
…-preview

Free Listings + Paid Ads: Add ad previews to the post-onboarding ads setup flow
@ianlin
Copy link
Member

ianlin commented Oct 14, 2022

I've tested it with the normal cases and confirmed everything works as expected.

@eason9487 eason9487 marked this pull request as ready for review October 18, 2022 04:39
@eason9487
Copy link
Member Author

Did a few rounds of overall testing and it worked well. Testing summary:

  • Google Merchant Center account
    • Connect to an existing Google Merchant Center account.
    • Connect to a newly created Google Merchant Center account without granting Google Ads access, and grant the Google Ads access in step 4.
  • Skip paid ads setup
    • The pop-up success modal has the content of paid ads promotion on the Product Feed page.
  • Continue paid ads setup
    • Connect to an existing Google Ads account with the already saved billing method.
    • Connect to a newly created Google Ads account.
    • Set up a billing method.
      • Open the pop-up window.
      • Open the alternative link.
    • Check the consistency of available target audience countries by going back to step 2, changing the target audience and then continuing to step 4.
    • Refresh the page anytime to check if it resumes the latest setup status during the onboarding flow.
    • Complete paid ads setup along with creating a paid campaign.
    • The pop-up success modal doesn't have the content of paid ads promotion on the Product Feed page.
  • Post-onboarding paid ads setup
    • Continue paid ads setup till connecting to a Google Ads account but skip the remaining campaign creation.
    • Go to the post-onboarding paid ads setup and resume it from the campaign creation step with the already connected Google Ads account.
    • Complete paid ads setup along with creating a new paid campaign.

@eason9487
Copy link
Member Author

I'm going to merge this PR since we are ready to ship it. 🤞

@eason9487 eason9487 merged commit 58a9bb2 into develop Oct 18, 2022
@eason9487 eason9487 deleted the feature/1610-streamlined-onboarding branch October 18, 2022 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ianlin ianlin

@eason9487 eason9487

Labels
changelog: add A new feature, function, or functionality was added.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Streamlined Free Listings plus Paid Ads for the onboarding flow
2 participants
@eason9487 @ianlin