Free Listings + Paid Ads: Add ad previews to the post-onboarding ads setup flow #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
changelog: add
35 tasks
puntope
reviewed
Oct 11, 2022
| @@ -26,6 +32,9 @@ import './campaign-preview.scss'; | |||
|
|
|||
| /** | |||
| * @typedef { import("./index.js").AdPreviewData } AdPreviewData | |||
| * | |||
| * @typedef {Object} CampaignPreviewHandler | |||
| * @property {(step: number) => void} moveBy Move the currently displayed preview ad by how many steps, e.g. 1 for moving to the next and -1 for the previous. | |||
There was a problem hiding this comment.
💅 I guess steps should be more accurate than step since ads far as I know it could be more than 1 step movement.
Besides that, since we don't use movements of more than one step. I guess it could be refactored as
move(backwards : bool = false) and move the preview one step backwards if backwards is true.
puntope
approved these changes
Oct 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR implements an item of the 📌 Post-onboarding setup flow in #1610.
Screenshots:
Kapture.2022-10-07.at.18.18.08.mp4
Detailed test instructions:
/wp-admin/admin.php?page=wc-admin&path=%2Fgoogle%2Fsetup-adsChangelog entry