-
Notifications
You must be signed in to change notification settings - Fork 417
opensearch-dashboards-3: bump to v3.3, follow tags for future updates, remediate GHSA-w48q-cv73-mx4w #75522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
opensearch-dashboards-3: bump to v3.3, follow tags for future updates, remediate GHSA-w48q-cv73-mx4w #75522
Conversation
Bumps the opensearch-dashboards-3 package to v3.3 manually because upstream forgot to actually publish a Github release. The [Opensearch blog post for release](https://opensearch.org/blog/explore-opensearch-3-3/) confirms the product was released, and we see a [proper release issued for Opensearch itself](https://github.com/opensearch-project/OpenSearch/releases/tag/3.3.0). As this is the second time in 6 months the Opensearch Dashboard has missed publishing a release, and because they've always cut tags accurately, we also set our automation to follow their tags for future updates.
Pin `@modelcontextprotocol/sdk==1.24.0` to remediate GHSA-w48q-cv73-mx4w. This change is also proposed upstream in opensearch-project/OpenSearch-Dashboards#10995, where the CI is passing but a human has not yet approved or merged.
🩹 Build Failed: Patch Application Failed
Build Details
Root Cause Analysis 🔍The patch CVE-2025-9287-fix.patch failed to apply to the package.json file. Hunk #1 of the patch could not be applied at line 127, indicating that the target code in package.json has changed from what the patch expects, making the patch incompatible with the current version of the OpenSearch-Dashboards source code at tag 3.3.0. 🔍 Build failure fix suggestionsFound similar build failures that have been fixed in the past and analyzed them to suggest a fix: Suggested ChangesFile: opensearch-dashboards-3.yaml
Content:
Replacement: Content: File: CVE-2025-9287-fix.patch
Click to expand fix analysisAnalysisThe similar fixes all follow a consistent pattern: when patches fail to apply due to version changes, the solution is to replace the incompatible patch with a new one that works with the current version, or to directly modify the package.json using inline JSON manipulation. All three examples removed failed patches (CVE-2025-7783-fix.patch, 2025-07-23-CVEs.patch) and replaced them with either new compatible patches or direct package.json modifications using jq commands. The fixes updated package versions, changed expected commits, and used runtime dependency resolution rather than patches when the source code had changed significantly. Click to expand fix explanationExplanationThis fix should work because it follows the exact pattern used in all similar failures. The root cause is that CVE-2025-9287-fix.patch was created for a different version of OpenSearch-Dashboards and the package.json structure has changed at line 127. Instead of trying to fix the patch, we remove it entirely and use the existing inline jq approach that's already being used successfully for other CVE fixes in the same file. The change from devDependencies to resolutions is important because resolutions provides stronger version enforcement across the entire dependency tree, which is more appropriate for security fixes. This approach is already proven to work in the build pipeline since similar CVE fixes are applied using the same method. Click to expand alternative approachesAlternative Approaches
Was this comment helpful? Please use 👍 or 👎 reactions on this comment. |
b6f0a44 to
79a45fc
Compare
79a45fc to
afc93ad
Compare
|
Removing sustaining from reviewer! |
Bumps the opensearch-dashboards-3 package to v3.3 manually because upstream forgot to actually publish a Github release. The Opensearch blog post for release confirms the product was released, and we see a proper release issued for Opensearch itself.
As this is the second time in 6 months the Opensearch Dashboard has missed publishing a release, and because they've always cut tags accurately, we also set our automation to follow their tags for future updates.
Also remediates GHSA-w48q-cv73-mx4w, which was previously remediated for opensearch-dashboards-2. This is bundled together with the package version bump as we know the CVE will exist.