Skip to content

Conversation

@vaikas
Copy link
Member

@vaikas vaikas commented Sep 7, 2023

Signed-off-by: Ville Aikas vaikas@chainguard.dev

Now when you ran yam it will sort the:
.environment.contents.packages and .package.dependencies.runtime for you.

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas vaikas requested a review from a team as a code owner September 7, 2023 01:42
Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
@vaikas vaikas requested a review from a team as a code owner September 7, 2023 01:50
@vaikas
Copy link
Member Author

vaikas commented Sep 7, 2023

Signed-off-by: Ville Aikas <vaikas@chainguard.dev>
Copy link
Member

@imjasonh imjasonh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should take a big pass through all the yamls and alphabetize them, so we don't get caught on this in each future dep bump or package change.

The change is a no-op though so it doesn't need new epochs / builds.

@vaikas vaikas added this pull request to the merge queue Sep 7, 2023
Merged via the queue into wolfi-dev:main with commit 0def7f2 Sep 7, 2023
@vaikas vaikas deleted the alpha-lint branch September 7, 2023 14:41
@vaikas
Copy link
Member Author

vaikas commented Sep 7, 2023

We should take a big pass through all the yamls and alphabetize them, so we don't get caught on this in each future dep bump or package change.

The change is a no-op though so it doesn't need new epochs / builds.

Yes, that would be nice: #5227

But looks like there are now lints that are catching problems that maybe weren't there when the files were introduced, so I'll tackle that once I get little more room on my plate.

Second problem however is that it is apparently building the entire world for no good reason, so everybody was assuming it would be a nop, but for some reason that assumption is not exactly right (or I screwed something else up?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants