-
Notifications
You must be signed in to change notification settings - Fork 419
alphabetize runtime / build deps for [a-c]*yaml. #4522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
If we wanted, we could even define those new sort rules in the repo's yam config file. And that way this sorting would be enforced in CI for future changes, too! And, locally, folks can just run We'd just add a new section to the config: sort:
- ".environment.contents.packages"
- ".package.dependencies.runtime" |
|
Yes! Maybe I got these steps backwards, but my thinking was, fix the existing stuff first (one big hit), then add the rules for pre-checks. |
|
That order sounds right to me, and I think it can be the same PR or separated PRs (unless I'm not thinking of something). Your approach SGTM! |
|
ooops, I apparently broke something... hang tight. |
|
hm, looks like ncurses failed: But the diff looks right? 🤔 ima retry in case it's a flake? |
|
Hm, maybe a rebase is needed? I don't think this failed on the first run? 🤔 |
|
Finally getting back to this: Will take care of: #4522 (comment) |
As discussed in: chainguard-dev/yam#27
run the following mechanical cleanup for packages sorting for [a-c]*yaml:
No functional changes, only cosmetic.