Skip to content

Conversation

@Dentrax
Copy link
Member

@Dentrax Dentrax commented Aug 18, 2023

This PR adds:

  • py3-absl-py.yaml
  • py3-asn1-modules.yaml
  • py3-blinker.yaml
  • py3-cachetools.yaml
  • py3-lru-dict.yaml
  • py3-oauthlib.yaml
  • py3-protobuf.yaml
  • py3-pyjwt.yaml
  • py3-websocket-client.yaml

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0
  • Patch source: patch source here

@Dentrax Dentrax changed the title Add some deps of metadata-writer Add some deps of metadata-writer and kubernetes Aug 18, 2023
@Dentrax Dentrax marked this pull request as ready for review August 18, 2023 21:44
@Dentrax Dentrax requested a review from a team as a code owner August 18, 2023 21:44
@Dentrax Dentrax requested review from denhamparry and luhring August 18, 2023 21:44
@rawlingsj
Copy link
Member

I’m guessing these were generated using melange convert python ? That’s something that was added after the initial apkbuild convert and I think there’s a little issue with it.
The generated URIs? i.e here contains a sha which means the wolfi bot wont be able to auto update them.

Most if not all projects are on GitHub i.e. this and so for the update bot to be able to maintain these new packages I think we need to switch them to git-checkout and have the update config use github rather than release monitor

Copy link
Member

@rawlingsj rawlingsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comments above, we need to avoid sha's in the download URI, we can use git-checkout instead

@rawlingsj rawlingsj mentioned this pull request Aug 18, 2023
7 tasks
@Dentrax Dentrax force-pushed the metadata-writer-some-deps branch 5 times, most recently from bb43bf4 to 6f16155 Compare August 19, 2023 22:22
Signed-off-by: Furkan Türkal <[email protected]>
Co-authored-by: Batuhan <[email protected]>
@Dentrax Dentrax force-pushed the metadata-writer-some-deps branch from 6f16155 to c996967 Compare August 19, 2023 22:24
@rawlingsj rawlingsj added this pull request to the merge queue Aug 21, 2023
Merged via the queue into wolfi-dev:main with commit 37ae21f Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants