-
Notifications
You must be signed in to change notification settings - Fork 419
katib python packages #4557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
katib python packages #4557
Conversation
cc696e5 to
eae5d43
Compare
ae6e378 to
c1316d7
Compare
rawlingsj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
similar to #4558 (comment) I just noticed that there's sha's in the fetch URL.
I'm sorry for the extra work but I think these need to be git-checkouts and have the update config track github rather than release monitor
Yes, I tried using |
do you have more details of what wasn't working? I just tried here switching the first two packages in this PR to github and the builds worked. I.e. package:
name: py3-cloudpickle
version: 2.2.1
epoch: 0
description: Extended pickling support for Python objects
copyright:
- license: BSD 3-Clause License
dependencies:
runtime:
- python3
environment:
contents:
packages:
- ca-certificates-bundle
- wolfi-base
- busybox
- build-base
- python3
- py3-setuptools
pipeline:
- uses: git-checkout
with:
repository: https://github.com/cloudpipe/cloudpickle
expected-commit: 917bed6bc63355f50aeb4f001683be7f172b6b88
tag: v${{package.version}}
- name: Python Build
runs: python setup.py build
- name: Python Install
runs: python setup.py install --prefix=/usr --root="${{targets.destdir}}"
- uses: strip
update:
ignore-regex-patterns:
- ^\.
enabled: true
github:
identifier: cloudpipe/cloudpickle
strip-prefix: v
use-tag: true
tag-filter: vand package:
name: py3-future
version: 0.18.3
epoch: 0
description: Clean single-source support for Python 3 and 2
copyright:
- license: MIT
dependencies:
runtime:
- python3
environment:
contents:
packages:
- ca-certificates-bundle
- wolfi-base
- busybox
- build-base
- python3
- py3-setuptools
pipeline:
- uses: git-checkout
with:
repository: https://github.com/PythonCharmers/python-future
expected-commit: af1db970b0879b59e7aeb798c27a623144561cff
tag: v${{package.version}}
- name: Python Build
runs: python setup.py build
- name: Python Install
runs: python setup.py install --prefix=/usr --root="${{targets.destdir}}"
- uses: strip
update:
enabled: true
github:
identifier: PythonCharmers/python-future
strip-prefix: v
The problem here is that we use different tooling to alpine, using APKBUILDs as a reference can help but we don't always want to do the exact same thing as wolfi is different. |
126be64 to
181e66b
Compare
b346ee2 to
c4f3c5f
Compare
Signed-off-by: Batuhan Apaydin <[email protected]>
c4f3c5f to
395f77d
Compare
Fixes:
Related:
Pre-review Checklist
For new package PRs only
For security-related PRs
For version bump PRs
epochfield is reset to 0