Skip to content

Conversation

@developer-guy
Copy link
Member

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0
  • Patch source: patch source here

@developer-guy developer-guy requested a review from a team as a code owner August 18, 2023 20:23
@developer-guy developer-guy force-pushed the feature/katib-python-packages branch 11 times, most recently from cc696e5 to eae5d43 Compare August 18, 2023 21:10
@developer-guy developer-guy force-pushed the feature/katib-python-packages branch 2 times, most recently from ae6e378 to c1316d7 Compare August 18, 2023 21:46
Copy link
Member

@rawlingsj rawlingsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

similar to #4558 (comment) I just noticed that there's sha's in the fetch URL.

I'm sorry for the extra work but I think these need to be git-checkouts and have the update config track github rather than release monitor

@developer-guy
Copy link
Member Author

similar to #4558 (comment) I just noticed that there's sha's in the fetch URL.

I'm sorry for the extra work but I think these need to be git-checkouts and have the update config track github rather than release monitor

Yes, I tried using git-checkout for those who work with git-checkout but some of them didn't work, so I kept using fetch from files.pythonhosted.org since APKBUILD does the same thing.

@rawlingsj
Copy link
Member

Yes, I tried using git-checkout for those who work with git-checkout but some of them didn't work, so I kept using fetch from files.pythonhosted.org since APKBUILD does the same thing.

do you have more details of what wasn't working? I just tried here switching the first two packages in this PR to github and the builds worked. I.e.

package:
  name: py3-cloudpickle
  version: 2.2.1
  epoch: 0
  description: Extended pickling support for Python objects
  copyright:
    - license: BSD 3-Clause License
  dependencies:
    runtime:
      - python3

environment:
  contents:
    packages:
      - ca-certificates-bundle
      - wolfi-base
      - busybox
      - build-base
      - python3
      - py3-setuptools

pipeline:
  - uses: git-checkout
    with:
      repository: https://github.com/cloudpipe/cloudpickle
      expected-commit: 917bed6bc63355f50aeb4f001683be7f172b6b88
      tag: v${{package.version}}

  - name: Python Build
    runs: python setup.py build

  - name: Python Install
    runs: python setup.py install --prefix=/usr --root="${{targets.destdir}}"

  - uses: strip

update:
  ignore-regex-patterns:
    - ^\.
  enabled: true
  github:
    identifier: cloudpipe/cloudpickle
    strip-prefix: v
    use-tag: true
    tag-filter: v

and

package:
  name: py3-future
  version: 0.18.3
  epoch: 0
  description: Clean single-source support for Python 3 and 2
  copyright:
    - license: MIT
  dependencies:
    runtime:
      - python3

environment:
  contents:
    packages:
      - ca-certificates-bundle
      - wolfi-base
      - busybox
      - build-base
      - python3
      - py3-setuptools

pipeline:
  - uses: git-checkout
    with:
      repository: https://github.com/PythonCharmers/python-future
      expected-commit: af1db970b0879b59e7aeb798c27a623144561cff
      tag: v${{package.version}}

  - name: Python Build
    runs: python setup.py build

  - name: Python Install
    runs: python setup.py install --prefix=/usr --root="${{targets.destdir}}"

  - uses: strip

update:
  enabled: true
  github:
    identifier: PythonCharmers/python-future
    strip-prefix: v

since APKBUILD does the same thing.

The problem here is that we use different tooling to alpine, using APKBUILDs as a reference can help but we don't always want to do the exact same thing as wolfi is different.

@developer-guy developer-guy force-pushed the feature/katib-python-packages branch 7 times, most recently from 126be64 to 181e66b Compare August 21, 2023 14:22
@developer-guy developer-guy force-pushed the feature/katib-python-packages branch 5 times, most recently from b346ee2 to c4f3c5f Compare August 21, 2023 16:51
Signed-off-by: Batuhan Apaydin <[email protected]>
@developer-guy developer-guy force-pushed the feature/katib-python-packages branch from c4f3c5f to 395f77d Compare August 21, 2023 17:01
@rawlingsj rawlingsj added this pull request to the merge queue Aug 22, 2023
Merged via the queue into wolfi-dev:main with commit 98dbcc9 Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants