Skip to content

tls-cipher fix#17859

Merged
xnox merged 4 commits intowolfi-dev:mainfrom
developer-guy:argocd-tlscipher-patch
Apr 26, 2024
Merged

tls-cipher fix#17859
xnox merged 4 commits intowolfi-dev:mainfrom
developer-guy:argocd-tlscipher-patch

Conversation

@developer-guy
Copy link
Member

@developer-guy developer-guy commented Apr 26, 2024

Fixes: argoproj/argo-cd#17569

Important

Once the change that was made by Josh released we should remove the patch file and update the argo-cd version but today instead of waiting the release we applied that change as a patch file**

/cc @joshrwolf @mamccorm

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

@developer-guy developer-guy force-pushed the argocd-tlscipher-patch branch from ac5127f to 493452c Compare April 26, 2024 09:45
@developer-guy developer-guy force-pushed the argocd-tlscipher-patch branch 6 times, most recently from dc29542 to 32d2761 Compare April 26, 2024 16:11
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
Co-authored-by: Furkan Turkal <furkan.turkal@chainguard.dev>
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
@developer-guy developer-guy force-pushed the argocd-tlscipher-patch branch from 32d2761 to 456c7e1 Compare April 26, 2024 18:12
@xnox
Copy link
Member

xnox commented Apr 26, 2024

everything looks fine, apart from editor settings, can you please run yam on the yaml file?

Signed-off-by: James Petersen <jpetersenames@gmail.com>
@found-it
Copy link
Contributor

found-it commented Apr 26, 2024

I went ahead and ran yam, thanks for putting this together @developer-guy!

Signed-off-by: James Petersen <jpetersenames@gmail.com>
@xnox xnox merged commit a4cbb3c into wolfi-dev:main Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants