Merged
Conversation
ac5127f to
493452c
Compare
dc29542 to
32d2761
Compare
Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev> Co-authored-by: Furkan Turkal <furkan.turkal@chainguard.dev> Signed-off-by: Batuhan Apaydin <batuhan.apaydin@chainguard.dev>
32d2761 to
456c7e1
Compare
Member
|
everything looks fine, apart from editor settings, can you please run yam on the yaml file? |
Signed-off-by: James Petersen <jpetersenames@gmail.com>
Contributor
|
I went ahead and ran yam, thanks for putting this together @developer-guy! |
Signed-off-by: James Petersen <jpetersenames@gmail.com>
xnox
approved these changes
Apr 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: argoproj/argo-cd#17569
Important
Once the change that was made by Josh released we should remove the patch file and update the argo-cd version but today instead of waiting the release we applied that change as a patch file**
/cc @joshrwolf @mamccorm
Related:
Pre-review Checklist
For new package PRs only
endoflife.date)For new version streams
name: ${{package.name}}-compat)provides:logical unversioned forms of the package (e.g.nodejs,nodejs-lts)For security-related PRs
For version bump PRs
epochfield is reset to 0For PRs that add patches