fix: remove deprecated default cipher for golang >=1.22

[joshrwolf]

Closes #17571

newer versions of go remove the TLS_RSA_WITH_AES_256_GCM_SHA384 as an available cipher.

this PR simply removes it in favor of the existing default TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384, which remains a valid default option for the existing go toolchain version, and future ones

Checklist:

• [] Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Toolchain Guide
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[blakepettersson]

Have you run make codegen? Which versions of Go does this apply for BTW?

[blakepettersson]

I see, golang/go#63413

[blakepettersson]

@joshrwolf I'll mark this PR as a draft until you run make codegen-local on your machine and commit those changes.

[agaudreault]

FYI, I had go 1.22 installed and running the codegen locally gave me errors with packages downloaded with go 1.22. After installing 1.21, re-downloading all the local toolings in dist/, I don't have the error anymore. Not sure if there is a bigger issue on upgrading argo to 1.22, but this might affect you.

See kubernetes-sigs/controller-tools#888

+ ./dist/gen-crd-spec
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
        panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x2 addr=0x0 pc=0x100ef4450]

Ref: kubernetes-sigs/controller-tools#888

[alexmt]

I took the liberty, run codegen and pushed changes to the branch (make clidocsgen to regenerate docs only)

[alexmt]

LGTM

[ashinsabu3]

Is this there in any released versions yet? @alexmt

[blakepettersson]

This is slated for 2.12; there's an RC out for it now.