Render Tile as div when there is no onClick #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will fix tests at the evening... |
|
I'm pretty sure Tile has to always be a button, because otherwise you can't select a tile. onClick will always be defined. |
|
Ok, so how can I render a calendar without any selection functionality? |
|
BTW, I'm using only the MonthView in my app, so it can be rendered without |
|
I gave this a thought and this could work, provided that we won't have any onClick passed to tiles, and this at the moment is always happening. Even if drillDown is not available (like on MonthView), there will be onChange passed. That's not good :( We would need to rethink some other areas of this package. |
Bumps [eslint-utils](https://github.com/mysticatea/eslint-utils) from 1.3.1 to 1.4.2. - [Release notes](https://github.com/mysticatea/eslint-utils/releases) - [Commits](mysticatea/eslint-utils@v1.3.1...v1.4.2) Signed-off-by: dependabot[bot] <[email protected]>
* [breaking] Remove react-lifecycles-compat polyfill * [breaking] Bump minimum React version to 16.3
* Implement defaultValue, defaultView, defaultActiveStartDate * Add onViewChange callback * Rename onActiveDateChange to onActiveStartDateChange * Prioritize activeStartDate over value when getting default active start date
… custom function (wojtekmaj#241) Fix an issue where Navigation for century view, decade view and year view would not have titles properly localized in th-TH locale Fix an issue where Decade and Year tiles would not have labels properly localized in th-TH locale Add support for custom formatYear function Add new tests for formatting tiles Fixes wojtekmaj#238
* Implement showDoubleView * Fix tests for Navigation component * Add unit tests for showDoubleView
* Add makeGetRange helper * Add isValidDate helper * Fixup makeGetRange * Fix test names * More compressed formatting of switch * Add makeGetEdgeOfNeighbor helper * Add docs * Add makeGetEdgeOfNeighborMonth helper * Remove getDifferentMonth function * Add comments * Add makeGetEnd helper * Refactor toYearLabel
wojtekmaj
force-pushed
the
main
branch
4 times, most recently
from
cef9c7c
to
cd7ef12
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
0f9c665
to
88f5da5
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
1f10b65
to
0c5a8da
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
d6fcc20
to
da505dd
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
3407450
to
7fc3da6
Compare
wojtekmaj
force-pushed
the
main
branch
3 times, most recently
from
9045b27
to
22f61e6
Compare
wojtekmaj
force-pushed
the
main
branch
2 times, most recently
from
dc4fd25
to
a8c5ad5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renders
divinstead ofbuttonwhenonClickmethod is not provided