Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 2.19.1 breaks IE11 #232

Closed
montogeek opened this issue Aug 29, 2019 · 5 comments
Closed

Version 2.19.1 breaks IE11 #232

montogeek opened this issue Aug 29, 2019 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@montogeek
Copy link

Hello!
After updating to version 2.19.1 from version 2.19.0. I got the following error in IE11:

image

This function is used by TileGroup component.

image

But I know that this isn't your code, it is code by Babel transformation, so it seems related to your change log entry "Syntax optimizations to make Babel output smaller.".

While checking changes between these 2 versions you update Babel related libraries.

This function implementation is really different between these 2 versions:
image and incompatible with IE11.

Do you think it is possible to revert this change or would you say to don't support IE11?

@montogeek
Copy link
Author

I have good news, this was fixed already in:
babel/babel#10171 and released in https://github.com/babel/babel/releases/tag/v7.5.2

So, Could you please upgrade to that Babel version?

@montogeek
Copy link
Author

According to this comment, it seems better to update to 7.5.4

@wojtekmaj wojtekmaj added the bug Something isn't working label Sep 6, 2019
@wojtekmaj wojtekmaj self-assigned this Sep 6, 2019
@wojtekmaj
Copy link
Owner

Thanks for letting me know about this problem. I'm on it.

@wojtekmaj
Copy link
Owner

v2.19.2 is out and should have this issue fixed. Sorry for the trouble.

@montogeek
Copy link
Author

@wojtekmaj Thank you!

felixmosh pushed a commit to felixmosh/react-calendar that referenced this issue Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants