-
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing interpreters now error the session on CI by default #567
Missing interpreters now error the session on CI by default #567
Conversation
I think some documentation is OK. Maybe a little note at https://nox.thea.codes/en/latest/tutorial.html#testing-against-different-and-multiple-pythons?
If that's the case, I would prefer some documentation, to say what this warning won't say? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good for me now :)
Can we make it so This has two advantages IMO:
|
Sure, that's a good idea, let me play around some more and get back to you 👍🏻 |
Huh, thought I had it working... standby 😂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Some minor suggestions inline.
Cool! Thanks for the review, should be good to go now if everyone's happy 🙂 |
Closes #340
This PR adds a check to determine if nox is running on CI when evaluating sessions with missing interpreters so that such sessions fail by default when being run on CI providers.
This has the desired effect:
Skipped locally showing CI warning
CI=true causes an error
Note non-zero exit code
--error-on-missing-interpreters
for referenceI have some questions I'd like people's input on:
--error-on-missing-interpreters
? Given that it will show any time a session is skipped a long message could get annoying.CI
existing inos.environ
should it explicitly check for true?