Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt for default behaviour change in nox #172

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

pradyunsg
Copy link
Member

Closes #171

This used to be the default in earlier releases of nox.
@pradyunsg
Copy link
Member Author

x-ref: wntrblm/nox#567

It's a suboptimal that they introduced behaviour difference between CI vs non-CI environments.

@pfmoore
Copy link
Member

pfmoore commented Sep 4, 2022

Agreed this is a better fix. Once this is merged I'll update #171 to just add 3.10 into CI. (And 3.11? I'm not sure how to spell "3.11rc1" for the github action and we'd have to change it once 3.11 final comes out, so maybe just wait till then)

@pradyunsg pradyunsg merged commit eeb743b into pypa:main Sep 4, 2022
@pradyunsg pradyunsg deleted the error-on-missing-interpreter branch September 4, 2022 12:13
@johnthagen
Copy link

johnthagen commented Sep 6, 2022

It's a suboptimal that they introduced behaviour difference between CI vs non-CI environments.

I opened this Nox issue that would hopefully make allow restoring the original behaviour in the noxfile.py itself. Please comment if you think this might also help/be preferred in your use case. I often find myself using the same Nox defaults as the pip team.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants