Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test sharding/parallelization #598

Closed
wants to merge 11 commits into from
Closed

test sharding/parallelization #598

wants to merge 11 commits into from

Conversation

doronpr
Copy link
Contributor

@doronpr doronpr commented Mar 4, 2018

  • moved e2e tests to jesr

@LeoNatan
Copy link
Contributor

LeoNatan commented Mar 6, 2018

#601 is blocking this. Should be fixed first before merging this.

@doronpr
Copy link
Contributor Author

doronpr commented Mar 6, 2018

@LeoNatan why blocker?
there's going to be a bug where PN isn't ready for parallelization but we can fix it when we get to it. No?

@LeoNatan
Copy link
Contributor

LeoNatan commented Mar 6, 2018 •
edited
Loading

I don't think that is the right approach. I think we should fix all known issues before merging this large PR.
In the case of #601, it's a very easy thing to fix.

@doronpr
Copy link
Contributor Author

doronpr commented Mar 6, 2018

closing in favour of #609

@doronpr doronpr closed this Mar 6, 2018
@LeoNatan LeoNatan deleted the jest-support branch March 12, 2018 20:03
@LeoNatan LeoNatan restored the jest-support branch March 12, 2018 20:03
@rotemmiz rotemmiz deleted the jest-support branch June 27, 2018 16:33
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@LeoNatan LeoNatan Awaiting requested review from LeoNatan

@rotemmiz rotemmiz Awaiting requested review from rotemmiz

Assignees
No one assigned
Labels
status: blocked type: enhancement ⚡️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doronpr @LeoNatan