Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

createPushNotificationJson creates a notification.json file under a constant path #601

Closed
LeoNatan opened this issue Mar 6, 2018 · 3 comments · Fixed by #623
Closed

createPushNotificationJson creates a notification.json file under a constant path #601

LeoNatan opened this issue Mar 6, 2018 · 3 comments · Fixed by #623
Assignees
@rotemmiz
Labels
status: accepted type: bug 🐞

Comments

@LeoNatan
Copy link
Contributor

LeoNatan commented Mar 6, 2018

This is no good if we want parallelization.
Path should either be generated using mktemp (and cleaned up after use), or it should contain enough process information to be unique per instance.
@LeoNatan LeoNatan mentioned this issue Mar 6, 2018
Closed
@LeoNatan
Copy link
Contributor Author

LeoNatan commented Mar 6, 2018

Also, the name is wrong, should be createUserNotificationJson 🙃

@LeoNatan
Copy link
Contributor Author

LeoNatan commented Mar 6, 2018

Blocker for #609

@LeoNatan LeoNatan mentioned this issue Mar 14, 2018
Merged
@LeoNatan
Copy link
Contributor Author

Fixed in a branch, will be closed eventually once branch lands.

LeoNatan added a commit that referenced this issue Mar 14, 2018
@LeoNatan
Make createUserNotificationFile parallel safe
c6680fa 
Closes #601
@LeoNatan LeoNatan mentioned this issue Mar 14, 2018
Merged
yershalom pushed a commit that referenced this issue Apr 4, 2018
@LeoNatan @yershalom
Make createUserNotificationFile parallel safe
1ed365f 
Closes #601
@wix wix locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rotemmiz rotemmiz

Labels
status: accepted type: bug 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

iOS: Add support for userActivity API wix/Detox
3 participants
@rotemmiz @LeoNatan @d4vidi